test/cctest/interpreter/bytecode_expectations/ArrayLiterals.golden - Issue 2640273002: [ignition] Expect 'I' for signed bytecode operands

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/interpreter/bytecode_expectations/ArrayLiterals.golden

Issue 2640273002: [ignition] Expect 'I' for signed bytecode operands (Closed)

Patch Set: Rebase Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « test/cctest/interpreter/bytecode-expectations-printer.cc ('k') | test/cctest/interpreter/bytecode_expectations/AssignmentsInBinaryExpression.golden » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: test/cctest/interpreter/bytecode_expectations/ArrayLiterals.golden

diff --git a/test/cctest/interpreter/bytecode_expectations/ArrayLiterals.golden b/test/cctest/interpreter/bytecode_expectations/ArrayLiterals.golden

index 2d57edf4a0614ecbfbebe57c0d02c73d2a918754..84d172fdf7c7dc705337e2f1de1a6d8e8cb45179 100644

--- a/test/cctest/interpreter/bytecode_expectations/ArrayLiterals.golden

+++ b/test/cctest/interpreter/bytecode_expectations/ArrayLiterals.golden

@@ -32,7 +32,7 @@ parameter count: 1

bytecode array length: 35

bytecodes: [

/* 30 E> */ B(StackCheck),

- /* 42 S> */ B(LdaSmi), U8(1),

+ /* 42 S> */ B(LdaSmi), I8(1),

B(Star), R(0),

/* 45 S> */ B(CreateArrayLiteral), U8(0), U8(0), U8(9),

B(Star), R(2),

@@ -40,9 +40,9 @@ bytecodes: [

B(Star), R(1),

B(Ldar), R(0),

/* 54 E> */ B(StaKeyedPropertySloppy), R(2), R(1), U8(3),

- B(LdaSmi), U8(1),

+ B(LdaSmi), I8(1),

B(Star), R(1),

- /* 59 E> */ B(AddSmi), U8(1), R(0), U8(2),

+ /* 59 E> */ B(AddSmi), I8(1), R(0), U8(2),

B(StaKeyedPropertySloppy), R(2), R(1), U8(3),

B(Ldar), R(2),

/* 66 S> */ B(Return),

@@ -80,7 +80,7 @@ parameter count: 1

bytecode array length: 65

bytecodes: [

/* 30 E> */ B(StackCheck),

- /* 42 S> */ B(LdaSmi), U8(1),

+ /* 42 S> */ B(LdaSmi), I8(1),

B(Star), R(0),

/* 45 S> */ B(CreateArrayLiteral), U8(0), U8(2), U8(0),

B(Star), R(2),

@@ -94,13 +94,13 @@ bytecodes: [

/* 56 E> */ B(StaKeyedPropertySloppy), R(4), R(3), U8(2),

B(Ldar), R(4),

B(StaKeyedPropertySloppy), R(2), R(1), U8(7),

- B(LdaSmi), U8(1),

+ B(LdaSmi), I8(1),

B(Star), R(1),

B(CreateArrayLiteral), U8(2), U8(1), U8(9),

B(Star), R(4),

B(LdaZero),

B(Star), R(3),

- /* 68 E> */ B(AddSmi), U8(2), R(0), U8(4),

+ /* 68 E> */ B(AddSmi), I8(2), R(0), U8(4),

B(StaKeyedPropertySloppy), R(4), R(3), U8(5),

B(Ldar), R(4),

B(StaKeyedPropertySloppy), R(2), R(1), U8(7),