Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Unified Diff: third_party/tcmalloc/chromium/src/thread_cache.h

Issue 2640263003: tcmalloc: Use the default TLS model on arm-gcc, CrOS only. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/tcmalloc/chromium/src/thread_cache.h
diff --git a/third_party/tcmalloc/chromium/src/thread_cache.h b/third_party/tcmalloc/chromium/src/thread_cache.h
index 221cacb8eb34b292c92b47d416a588a5b8fd019d..983676749767fb78187f40d0438a2cb1e87651d6 100644
--- a/third_party/tcmalloc/chromium/src/thread_cache.h
+++ b/third_party/tcmalloc/chromium/src/thread_cache.h
@@ -268,7 +268,11 @@ class ThreadCache {
// for instrumentation (-fprofile-generate).
// For all non-instrumentation builds, this define will not be set and the
// performance benefit of "intial-exec" will be achieved.
-#if defined(HAVE___ATTRIBUTE__) && !defined(PGO_GENERATE)
+ //
+ // gcc has a problem with this tls model on arm.
+ // See https://bugs.chromium.org/p/chromium/issues/detail?id=650137
+#if defined(HAVE___ATTRIBUTE__) && !defined(PGO_GENERATE) && \
+ (defined(__clang__) || !defined(OS_CHROMEOS) || !defined(__arm__))
__attribute__ ((tls_model ("initial-exec")))
# endif
;

Powered by Google App Engine
This is Rietveld 408576698