Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 2640253002: VM: [Kernel] Fix invocation of _AssertionError._create (Closed)

Created:
3 years, 11 months ago by kustermann
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: [Kernel] Fix invocation of _AssertionError._create A CL a few weeks ago added one more argument to the constructor (see https://codereview.chromium.org/2574003003) R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/6a4d70ef3a156f5a5a236757ff81a12d9da033fa

Patch Set 1 #

Patch Set 2 : status file update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -11 lines) Patch
M runtime/vm/kernel_to_il.cc View 4 chunks +7 lines, -4 lines 0 comments Download
M tests/language/language_kernel.status View 1 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
kustermann
3 years, 11 months ago (2017-01-19 09:33:02 UTC) #2
Vyacheslav Egorov (Google)
lgtm
3 years, 11 months ago (2017-01-19 09:58:32 UTC) #3
kustermann
3 years, 11 months ago (2017-01-19 10:00:04 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
6a4d70ef3a156f5a5a236757ff81a12d9da033fa (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698