Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(697)

Side by Side Diff: components/bubble/bubble_manager.h

Issue 2640223004: Remove ScopedVector in //components/bubble. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/bubble/bubble_manager.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_BUBBLE_BUBBLE_MANAGER_H_ 5 #ifndef COMPONENTS_BUBBLE_BUBBLE_MANAGER_H_
6 #define COMPONENTS_BUBBLE_BUBBLE_MANAGER_H_ 6 #define COMPONENTS_BUBBLE_BUBBLE_MANAGER_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <vector>
9 10
10 #include "base/macros.h" 11 #include "base/macros.h"
11 #include "base/memory/scoped_vector.h"
12 #include "base/observer_list.h" 12 #include "base/observer_list.h"
13 #include "base/threading/thread_checker.h" 13 #include "base/threading/thread_checker.h"
14 #include "components/bubble/bubble_close_reason.h" 14 #include "components/bubble/bubble_close_reason.h"
15 #include "components/bubble/bubble_reference.h" 15 #include "components/bubble/bubble_reference.h"
16 16
17 class BubbleDelegate; 17 class BubbleDelegate;
18 18
19 namespace content { 19 namespace content {
20 class RenderFrameHost; 20 class RenderFrameHost;
21 } 21 }
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
95 95
96 base::ObserverList<BubbleManagerObserver> observers_; 96 base::ObserverList<BubbleManagerObserver> observers_;
97 97
98 // Verify that functions that affect the UI are done on the same thread. 98 // Verify that functions that affect the UI are done on the same thread.
99 base::ThreadChecker thread_checker_; 99 base::ThreadChecker thread_checker_;
100 100
101 // Determines what happens to a bubble when |ShowBubble| is called. 101 // Determines what happens to a bubble when |ShowBubble| is called.
102 ManagerState manager_state_; 102 ManagerState manager_state_;
103 103
104 // The bubbles that are being managed. 104 // The bubbles that are being managed.
105 ScopedVector<BubbleController> controllers_; 105 std::vector<std::unique_ptr<BubbleController>> controllers_;
106 106
107 DISALLOW_COPY_AND_ASSIGN(BubbleManager); 107 DISALLOW_COPY_AND_ASSIGN(BubbleManager);
108 }; 108 };
109 109
110 #endif // COMPONENTS_BUBBLE_BUBBLE_MANAGER_H_ 110 #endif // COMPONENTS_BUBBLE_BUBBLE_MANAGER_H_
OLDNEW
« no previous file with comments | « no previous file | components/bubble/bubble_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698