Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1112)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/android/java/res/layout/bottom_control_container.xml

Issue 2640223002: Attach NTP to Chrome Home bottom sheet (Closed)
Patch Set: rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/widget/BottomSheet.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/res/layout/bottom_control_container.xml
diff --git a/chrome/android/java/res/layout/bottom_control_container.xml b/chrome/android/java/res/layout/bottom_control_container.xml
index 1153e0af1c9f78b16aaaf1210445bef0d0bcb24b..c27261da36c922bab81086d885c327c5f3291bf8 100644
--- a/chrome/android/java/res/layout/bottom_control_container.xml
+++ b/chrome/android/java/res/layout/bottom_control_container.xml
@@ -43,10 +43,16 @@
</view>
</org.chromium.chrome.browser.toolbar.ToolbarControlContainer>
- <View
+ <FrameLayout
android:id="@+id/bottom_sheet_content"
android:layout_width="match_parent"
- android:layout_height="match_parent"
- android:background="@android:color/white" />
+ android:layout_height="match_parent">
gone 2017/01/23 19:48:39 nit: space before > to match the rest of the file.
mdjones 2017/01/24 01:37:24 Done.
+
+ <View
+ android:layout_width="match_parent"
+ android:layout_height="match_parent"
+ android:background="@android:color/white" />
+
+ </FrameLayout>
</org.chromium.chrome.browser.widget.BottomSheet>
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/widget/BottomSheet.java » ('J')

Powered by Google App Engine
This is Rietveld 408576698