chrome/android/java/res/layout/bottom_control_container.xml - Issue 2640223002: Attach NTP to Chrome Home bottom sheet

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/res/layout/bottom_control_container.xml

Issue 2640223002: Attach NTP to Chrome Home bottom sheet (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/android/java/res/layout/bottom_control_container.xml

diff --git a/chrome/android/java/res/layout/bottom_control_container.xml b/chrome/android/java/res/layout/bottom_control_container.xml

index cdce8a967f7d09d7cb964d75cfca43940f8275db..d4a7b797dadab4685be26aaf9a7559464d51af01 100644

--- a/chrome/android/java/res/layout/bottom_control_container.xml

+++ b/chrome/android/java/res/layout/bottom_control_container.xml

@@ -44,10 +44,16 @@

</view>

</org.chromium.chrome.browser.toolbar.ToolbarControlContainer>

- <View

+ <FrameLayout

android:id="@+id/bottom_sheet_content"

android:layout_width="match_parent"

- android:layout_height="match_parent"

- android:background="@android:color/white" />

+ android:layout_height="match_parent">

+ <View

+ android:layout_width="match_parent"

Ian Wen 2017/01/25 19:55:44 SetWillDraw() can help you draw white background f

mdjones 2017/01/25 19:57:25 Removed the need for this.

+ android:layout_height="match_parent"

+ android:background="@android:color/white" />

+ </FrameLayout>

</org.chromium.chrome.browser.widget.BottomSheet>

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java » ('j') | no next file with comments »