Update host verification API

Update host verification API

- Rename VerifyHostFiles() to VerifyHost_0().
- Let VerifyHost_0() return a boolean.

BUG=658036
R=jrummell@chromium.org, tinskip@chromium.org

Committed: https://chromium.googlesource.com/chromium/cdm/+/f45b8d91baa263aee8705455c0794232626d1708

[xhwang, 2017-01-19 18:21:21]

xhwang@chromium.org changed reviewers:
+ ddorwin@chromium.org, jrummell@chromium.org, tinskip@chromium.org

[xhwang, 2017-01-19 18:21:21]

xhwang@chromium.org changed required reviewers:
+ tinskip@chromium.org

[xhwang, 2017-01-19 18:21:22]

Changes upon tinskip's request :)

tinskip: PTAL
ddorwin / jrummell: FYI

[xhwang, 2017-01-19 18:21:52]

xhwang@chromium.org changed reviewers:
- ddorwin@chromium.org, jrummell@chromium.org

[xhwang, 2017-01-19 18:21:52]

hmchen: FYI as well.

[tinskip1, 2017-01-19 18:31:01]

lgtm

[jrummell, 2017-01-19 18:44:19]

jrummell@chromium.org changed reviewers:
+ jrummell@chromium.org

[jrummell, 2017-01-19 18:44:19]

lgtm (although not needed from me)

https://codereview.chromium.org/2640203003/diff/1/content_decryption_module_e...
File content_decryption_module_ext.h (right):

https://codereview.chromium.org/2640203003/diff/1/content_decryption_module_e...
content_decryption_module_ext.h:52: // Functions in this file are dynamically
retrieved by their versioned fucntion
s/fucntion/function/ (last word on line).

https://codereview.chromium.org/2640203003/diff/1/content_decryption_module_e...
content_decryption_module_ext.h:61: CDM_API bool VerifyHost_0(const
cdm::HostFile* host_files, uint32_t num_files);
Should we also have the typedef for the calling signature here? I noticed in
your chrome change it simply referred to this file, but I wondered if it would
be better to have the typedef here. (And possibly the function name, although I
think #define VerifyHostFunctionName VerifyHost_0 is discouraged.)

[xhwang, 2017-01-19 19:42:18]

https://codereview.chromium.org/2640203003/diff/1/content_decryption_module_e...
File content_decryption_module_ext.h (right):

https://codereview.chromium.org/2640203003/diff/1/content_decryption_module_e...
content_decryption_module_ext.h:52: // Functions in this file are dynamically
retrieved by their versioned fucntion
On 2017/01/19 18:44:19, jrummell wrote:
> s/fucntion/function/ (last word on line).

Done.

https://codereview.chromium.org/2640203003/diff/1/content_decryption_module_e...
content_decryption_module_ext.h:61: CDM_API bool VerifyHost_0(const
cdm::HostFile* host_files, uint32_t num_files);
On 2017/01/19 18:44:19, jrummell wrote:
> Should we also have the typedef for the calling signature here? I noticed in
> your chrome change it simply referred to this file, but I wondered if it would
> be better to have the typedef here. (And possibly the function name, although
I
> think #define VerifyHostFunctionName VerifyHost_0 is discouraged.)

Summary of offline discussion.

Typically we don't do them in the header file to keep the interface clean. Also
looking at all examples in Chromium and we don't normally do this. So I'll keep
this as is for now. We can revisit this topic later.

[xhwang, 2017-01-19 19:50:48]

Description was changed from

==========
Update host verification API

- Rename VerifyHostFiles() to VerifyHost_0().
- Let VerifyHost_0() return a boolean.

BUG=658036
==========

to

==========
Update host verification API

- Rename VerifyHostFiles() to VerifyHost_0().
- Let VerifyHost_0() return a boolean.

BUG=658036
R=jrummell@chromium.org, tinskip@chromium.org

Committed:
https://chromium.googlesource.com/chromium/cdm/+/f45b8d91baa263aee8705455c079...
==========

[xhwang, 2017-01-19 19:50:49]

Committed patchset #2 (id:20001) manually as
f45b8d91baa263aee8705455c0794232626d1708 (presubmit successful).