Issue 264017: Remove a valgrind suppression which isn't being used....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 264017: Remove a valgrind suppression which isn't being used.... (Closed)

Created:
11 years, 2 months ago by eroman

Modified:
9 years, 6 months ago

Reviewers:
dank

CC:
chromium-reviews_googlegroups.com, not_the_right_glider, Nirnimesh, Timur Iskhodzhanov, stuartmorgan, pam+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Remove a valgrind suppression which isn't being used. This hasn't shown up on the buildbots during the past 40 cycles of: Chromium Mac (valgrind) Chromium Mac UI (valgrind)(1) Chromium Mac UI (valgrind)(2) Chromium Mac UI (valgrind)(3) Linux Tests (valgrind)(1) Linux Tests (valgrind)(2) Linux Tests (valgrind)(3) Linux Tests (valgrind)(4) Webkit Linux (valgrind) Webkit_Linux_(valgrind_layout) BUG=22559 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28466

Patch Set 1 #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -40 lines)			Patch
	M	tools/valgrind/memcheck/suppressions.txt	View		1 chunk	+0 lines, -40 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

dank

LGTM (though you'll want to grep the mac bots too just in case)

11 years, 2 months ago (2009-10-08 22:39:59 UTC) #2

eroman

11 years, 2 months ago (2009-10-08 22:42:33 UTC) #3

> LGTM (though you'll want to grep the mac bots too just in case)

Done. I expanded the search so it now includes all of:

   Chromium Mac (valgrind)
   Chromium Mac UI (valgrind)(1)
   Chromium Mac UI (valgrind)(2)
   Chromium Mac UI (valgrind)(3)
   Linux Tests (valgrind)(1)
   Linux Tests (valgrind)(2)
   Linux Tests (valgrind)(3)
   Linux Tests (valgrind)(4)
   Webkit Linux (valgrind)
   Webkit_Linux_(valgrind_layout)

Expand Messages | Collapse Messages