Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 2640163005: Add a changelog entry for `Null`. (Closed)

Created:
3 years, 11 months ago by floitsch
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M CHANGELOG.md View 1 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
floitsch
3 years, 11 months ago (2017-01-19 12:37:03 UTC) #2
Lasse Reichstein Nielsen
lgtm https://codereview.chromium.org/2640163005/diff/1/CHANGELOG.md File CHANGELOG.md (right): https://codereview.chromium.org/2640163005/diff/1/CHANGELOG.md#newcode33 CHANGELOG.md:33: it is considered a subtype of every other ...
3 years, 11 months ago (2017-01-19 13:58:47 UTC) #3
floitsch
Committed patchset #2 (id:20001) manually as b002a1781168b7f0c64264c9f5b569f2b48aa7d2 (presubmit successful).
3 years, 11 months ago (2017-01-19 14:18:30 UTC) #5
floitsch
3 years, 11 months ago (2017-01-19 14:18:54 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/2640163005/diff/1/CHANGELOG.md
File CHANGELOG.md (right):

https://codereview.chromium.org/2640163005/diff/1/CHANGELOG.md#newcode33
CHANGELOG.md:33: it is considered a subtype of every other type.
On 2017/01/19 13:58:47, Lasse Reichstein Nielsen wrote:
> (Not technically true, since bottom exists, but let's not confuse the reader:
)

Acknowledged.

https://codereview.chromium.org/2640163005/diff/1/CHANGELOG.md#newcode41
CHANGELOG.md:41: List<Null> bar() => [];
On 2017/01/19 13:58:47, Lasse Reichstein Nielsen wrote:
> Add the type parameter to the literal as well, just for good measure.

Done.

Powered by Google App Engine
This is Rietveld 408576698