third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteStatement.cpp - Issue 2640163004: Replace ENABLE(ASSERT) with DCHECK_IS_ON().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteStatement.cpp

Issue 2640163004: Replace ENABLE(ASSERT) with DCHECK_IS_ON(). (Closed)

Patch Set: m_domTreeVersion initialization Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteStatement.h ('k') | third_party/WebKit/Source/platform/audio/android/FFTFrameOpenMAXDLAndroid.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteStatement.cpp

diff --git a/third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteStatement.cpp b/third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteStatement.cpp

index b7e2c3394422e478fb37376b43c85616f8c9f1b7..b2ad12057b2fc7cd190b568d105ad60cd932aeb0 100644

--- a/third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteStatement.cpp

+++ b/third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteStatement.cpp

@@ -82,10 +82,6 @@ SQLiteStatement::SQLiteStatement(SQLiteDatabase& db, const String& sql)

: m_database(db),

m_query(sql),

m_statement(0)

-#if ENABLE(ASSERT)

- ,

- m_isPrepared(false)

-#endif

{

}

@@ -127,7 +123,7 @@ int SQLiteStatement::prepare() {

else if (*tail && **tail)

error = SQLITE_ERROR;

-#if ENABLE(ASSERT)

+#if DCHECK_IS_ON()

m_isPrepared = error == SQLITE_OK;

#endif

return restrictError(error);

@@ -156,7 +152,7 @@ int SQLiteStatement::step() {

}

int SQLiteStatement::finalize() {

-#if ENABLE(ASSERT)

+#if DCHECK_IS_ON()

m_isPrepared = false;

#endif

if (!m_statement)