third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp - Issue 2640163004: Replace ENABLE(ASSERT) with DCHECK_IS_ON().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp

Issue 2640163004: Replace ENABLE(ASSERT) with DCHECK_IS_ON(). (Closed)

Patch Set: m_domTreeVersion initialization Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.h ('k') | third_party/WebKit/Source/modules/crypto/NormalizeAlgorithm.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp

diff --git a/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp b/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp

index 6de9215e570e6b09282ed938542ea425390b6779..7215255a5f69aa4114ac41f476cffbeb4dea16e8 100644

--- a/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp

+++ b/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp

@@ -93,9 +93,6 @@ AXObjectCache* AXObjectCacheImpl::create(Document& document) {

AXObjectCacheImpl::AXObjectCacheImpl(Document& document)

: m_document(document),

m_modificationCount(0),

-#if ENABLE(ASSERT)

- m_hasBeenDisposed(false),

-#endif

m_notificationPostTimer(this,

&AXObjectCacheImpl::notificationPostTimerFired) {

}

@@ -113,7 +110,7 @@ void AXObjectCacheImpl::dispose() {

removeAXID(obj);

}

-#if ENABLE(ASSERT)

+#if DCHECK_IS_ON()

m_hasBeenDisposed = true;

#endif

}

@@ -640,7 +637,7 @@ void AXObjectCacheImpl::notificationPostTimerFired(TimerBase*) {

if (obj->isDetached())

continue;

-#if ENABLE(ASSERT)

+#if DCHECK_IS_ON()

// Make sure none of the layout views are in the process of being layed out.

// Notifications should only be sent after the layoutObject has finished

if (obj->isAXLayoutObject()) {