third_party/WebKit/Source/core/page/Page.h - Issue 2640163004: Replace ENABLE(ASSERT) with DCHECK_IS_ON().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/Page.h

Issue 2640163004: Replace ENABLE(ASSERT) with DCHECK_IS_ON(). (Closed)

Patch Set: m_domTreeVersion initialization Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/page/Page.h

diff --git a/third_party/WebKit/Source/core/page/Page.h b/third_party/WebKit/Source/core/page/Page.h

index 918050f7cfe70dd2e88050216b452d7c084fd070..133260a54178c5fa4c0b3f3ce9a3fac74f875156 100644

--- a/third_party/WebKit/Source/core/page/Page.h

+++ b/third_party/WebKit/Source/core/page/Page.h

@@ -213,7 +213,7 @@ class CORE_EXPORT Page final : public GarbageCollectedFinalized<Page>,

bool isCursorVisible() const;

void setIsCursorVisible(bool isVisible) { m_isCursorVisible = isVisible; }

-#if ENABLE(ASSERT)

+#if DCHECK_IS_ON()

void setIsPainting(bool painting) { m_isPainting = painting; }

bool isPainting() const { return m_isPainting; }

#endif

@@ -295,8 +295,8 @@ class CORE_EXPORT Page final : public GarbageCollectedFinalized<Page>,

bool m_isCursorVisible;

-#if ENABLE(ASSERT)

- bool m_isPainting;

+#if DCHECK_IS_ON()

+ bool m_isPainting = false;

#endif

// A pointer to all the interfaces provided to in-process Frames for this