Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptState.cpp

Issue 2640163004: Replace ENABLE(ASSERT) with DCHECK_IS_ON(). (Closed)
Patch Set: m_domTreeVersion initialization Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ScriptState.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptState.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptState.cpp
index c16c328bdb4d2858ef9a77cc10cf9455b9f26961..8f84ae25f1a8ea20c97c726b9420897f734f5234 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptState.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptState.cpp
@@ -36,10 +36,6 @@ ScriptState::ScriptState(v8::Local<v8::Context> context,
m_context(m_isolate, context),
m_world(world),
m_perContextData(V8PerContextData::create(context))
-#if ENABLE(ASSERT)
- ,
- m_globalObjectDetached(false)
-#endif
{
DCHECK(m_world);
m_context.setWeak(this, &weakCallback);
@@ -54,7 +50,7 @@ ScriptState::~ScriptState() {
void ScriptState::detachGlobalObject() {
ASSERT(!m_context.isEmpty());
context()->DetachGlobal();
-#if ENABLE(ASSERT)
+#if DCHECK_IS_ON()
m_globalObjectDetached = true;
#endif
}

Powered by Google App Engine
This is Rietveld 408576698