Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.h

Issue 2640163004: Replace ENABLE(ASSERT) with DCHECK_IS_ON(). (Closed)
Patch Set: m_domTreeVersion initialization Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.h b/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.h
index 3a62b455495e05585200cac345e1e821539061a7..0258371a85e273d050ff8180fa31f466f4d78ef0 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.h
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.h
@@ -41,7 +41,7 @@ class CORE_EXPORT ScriptPromiseResolver
return resolver;
}
-#if ENABLE(ASSERT)
+#if DCHECK_IS_ON()
// Eagerly finalized so as to ensure valid access to getExecutionContext()
// from the destructor's assert.
EAGERLY_FINALIZE();
@@ -78,7 +78,7 @@ class CORE_EXPORT ScriptPromiseResolver
// Note that an empty ScriptPromise will be returned after resolve or
// reject is called.
ScriptPromise promise() {
-#if ENABLE(ASSERT)
+#if DCHECK_IS_ON()
m_isPromiseCalled = true;
#endif
return m_resolver.promise();
@@ -161,9 +161,9 @@ class CORE_EXPORT ScriptPromiseResolver
// alive while in that state.
SelfKeepAlive<ScriptPromiseResolver> m_keepAlive;
-#if ENABLE(ASSERT)
+#if DCHECK_IS_ON()
// True if promise() is called.
- bool m_isPromiseCalled;
+ bool m_isPromiseCalled = false;
#endif
};

Powered by Google App Engine
This is Rietveld 408576698