Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptFunction.h

Issue 2640163004: Replace ENABLE(ASSERT) with DCHECK_IS_ON(). (Closed)
Patch Set: m_domTreeVersion initialization Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ScriptFunction.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptFunction.h b/third_party/WebKit/Source/bindings/core/v8/ScriptFunction.h
index 6a7f96e1d4119c5e6ae169066dfa47f15d3971a9..3a4b1508b956e5c71c73b04836187bbbe188aa51 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptFunction.h
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptFunction.h
@@ -59,10 +59,6 @@ class CORE_EXPORT ScriptFunction
protected:
explicit ScriptFunction(ScriptState* scriptState)
: m_scriptState(scriptState)
-#if ENABLE(ASSERT)
- ,
- m_bindToV8FunctionAlreadyCalled(false)
-#endif
{
}
@@ -75,9 +71,9 @@ class CORE_EXPORT ScriptFunction
static void callCallback(const v8::FunctionCallbackInfo<v8::Value>&);
RefPtr<ScriptState> m_scriptState;
-#if ENABLE(ASSERT)
+#if DCHECK_IS_ON()
// bindToV8Function must not be called twice.
- bool m_bindToV8FunctionAlreadyCalled;
+ bool m_bindToV8FunctionAlreadyCalled = false;
#endif
};

Powered by Google App Engine
This is Rietveld 408576698