Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ExceptionState.h

Issue 2640163004: Replace ENABLE(ASSERT) with DCHECK_IS_ON(). (Closed)
Patch Set: m_domTreeVersion initialization Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ExceptionState.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/ExceptionState.h b/third_party/WebKit/Source/bindings/core/v8/ExceptionState.h
index c34c579fd3e5089afd40202f293c0611c6654b35..fd45146001944ae4560b538156ddf3ed3fc795a5 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ExceptionState.h
+++ b/third_party/WebKit/Source/bindings/core/v8/ExceptionState.h
@@ -83,7 +83,7 @@ class CORE_EXPORT ExceptionState {
ContextType contextType,
const char* interfaceName)
: ExceptionState(isolate, contextType, interfaceName, nullptr) {
-#if ENABLE(ASSERT)
+#if DCHECK_IS_ON()
switch (m_context) {
case ConstructionContext:
case EnumerationContext:
@@ -94,7 +94,7 @@ class CORE_EXPORT ExceptionState {
default:
NOTREACHED();
}
-#endif // ENABLE(ASSERT)
+#endif // DCHECK_IS_ON()
}
~ExceptionState() {
@@ -176,7 +176,7 @@ class CORE_EXPORT NonThrowableExceptionState final : public ExceptionState {
// This can be used as a default value of an ExceptionState parameter like this:
//
// Node* removeChild(Node*, ExceptionState& = ASSERT_NO_EXCEPTION);
-#if ENABLE(ASSERT)
+#if DCHECK_IS_ON()
#define ASSERT_NO_EXCEPTION \
(::blink::NonThrowableExceptionState(__FILE__, __LINE__).returnThis())
#else

Powered by Google App Engine
This is Rietveld 408576698