third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp - Issue 2640163004: Replace ENABLE(ASSERT) with DCHECK_IS_ON().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp

Issue 2640163004: Replace ENABLE(ASSERT) with DCHECK_IS_ON(). (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/frame/LocalFrame.cpp ('K') | « third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp ('k') | third_party/WebKit/Source/core/layout/compositing/GraphicsLayerTreeBuilder.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp

diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp

index ffc437e55e96769d9ec8c31bc2193e67288fce1f..69a2df22df2454c5bf7c59ec908875a5552f94f5 100644

--- a/third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp

+++ b/third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp

@@ -157,7 +157,7 @@ class CompositingRequirementsUpdater::RecursionData {

};

static bool requiresCompositingOrSquashing(CompositingReasons reasons) {

-#if ENABLE(ASSERT)

+#if DCHECK_IS_ON()

bool fastAnswer = reasons != CompositingReasonNone;

bool slowAnswer = requiresCompositing(reasons) || requiresSquashing(reasons);

DCHECK_EQ(slowAnswer, fastAnswer);

@@ -379,7 +379,7 @@ void CompositingRequirementsUpdater::updateRecursive(

childRecursionData.m_testingOverlap = true;

}

-#if ENABLE(ASSERT)

+#if DCHECK_IS_ON()

LayerListMutationDetector mutationChecker(layer->stackingNode());

#endif