third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp - Issue 2640163004: Replace ENABLE(ASSERT) with DCHECK_IS_ON().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp

Issue 2640163004: Replace ENABLE(ASSERT) with DCHECK_IS_ON(). (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.h ('k') | third_party/WebKit/Source/core/clipboard/DataObject.cpp » ('j') | third_party/WebKit/Source/core/frame/LocalFrame.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp

diff --git a/third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp b/third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp

index 60c44f6407b0c9a45c5b1823b862291b8e46bdd6..7f2bdfc2ab75ece2dfe40793252dbbfc4ea7244e 100644

--- a/third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp

+++ b/third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp

@@ -594,7 +594,7 @@ IDBKeyRange* NativeValueTraits<IDBKeyRange*>::nativeValue(

return V8IDBKeyRange::toImplWithTypeCheck(isolate, value);

}

-#if ENABLE(ASSERT)

+#if DCHECK_IS_ON()

// This assertion is used when a value has been retrieved from an object store

// with implicit keys (i.e. a key path). It verifies that either the value

// contains an implicit key matching the primary key (so it was correctly