Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Unified Diff: third_party/WebKit/Source/core/loader/FrameFetchContext.cpp

Issue 2640163002: Doc.write intervention warning and error messages fixed for clarity. (Closed)
Patch Set: Updated tests Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
diff --git a/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp b/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
index 49da59a570a93cc2708406d77327dc1f3f0540ca..c53b1e144f75ffc1f443a69d7a5f63633f4e4a9c 100644
--- a/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
+++ b/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
@@ -90,8 +90,10 @@ namespace {
void emitWarningForDocWriteScripts(const String& url, Document& document) {
String message =
"A Parser-blocking, cross site (i.e. different eTLD+1) script, " + url +
- ", is invoked via document.write. This may be blocked by "
- "the browser if the device has poor network connectivity. "
+ ", is invoked via document.write. This MAY be blocked by "
+ "the browser in this or a future page load due to poor network "
+ "connectivity. If blocked in this page load, it will be confirmed in a "
+ "subsequent message."
Bryan McQuade 2017/01/24 16:45:26 nit: maybe 'subsequent console message'? reading t
shivanisha 2017/01/24 17:22:38 Done.
"See https://www.chromestatus.com/feature/5718547946799104 "
"for more details.";
document.addConsoleMessage(

Powered by Google App Engine
This is Rietveld 408576698