DescriptionFixed position with left:auto was broken because element's static position
was not propagated to old layout.
computeLogicalWidth(computedValues) eventually uses
layer()->getStaticInlinePosition
for positioning if left or top are not set.
We were not saving this value. I fixed it by saving the value inside the builder.
The reason for using builder is code reuse among different algorithms.
The fix makes 3 more tests pass.
Example:
<p>Yo</p>
<div id="div1" style="position:fixed:width:9px;height:9px;background-color:yellow" ></div>
BUG=635619
[ng_save_static]
Review-Url: https://codereview.chromium.org/2640153002
Cr-Commit-Position: refs/heads/master@{#444577}
Committed: https://chromium.googlesource.com/chromium/src/+/846a1b9762d89d23f293b0492df433e2239f71f5
Patch Set 1 #
Total comments: 2
Patch Set 2 : LegacySaveStaticOffset -> SaveStaticOffsetForLegacy #
Total comments: 3
Patch Set 3 : conflict rebase #
Messages
Total messages: 22 (12 generated)
|