Support subpixel layout for borders.

third_party/WebKit/Source/core/style/ComputedStyle.h

 /*
  * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
  *           (C) 2000 Antti Koivisto (koivisto@kde.org)
  *           (C) 2000 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2003, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All
  * rights reserved.
  * Copyright (C) 2006 Graham Dennis (graham.dennis@gmail.com)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ skipping 85 matching lines @@
   group.access()->base.access()->variable = value
 
 #define SET_VAR_WITH_SETTER(group, getter, setter, value) \
   if (!compareEqual(group->getter(), value))              \
   group.access()->setter(value)
 
 #define SET_BORDERVALUE_COLOR(group, variable, value) \
   if (!compareEqual(group->variable.color(), value))  \
   group.access()->variable.setColor(value)
 
+#define SET_BORDER_WIDTH(group, variable, value) \
+  if (!group->variable.widthEquals(value))       \
+  group.access()->variable.setWidth(value)

[pdr., 2017/01/27 20:28:44]

Nit: should this line be indented?

[Karl Øygard, 2017/02/10 12:53:18]

I agree, but the formatter disagrees...

+
+#define SET_NESTED_BORDER_WIDTH(group, base, variable, value) \
+  if (!group->base->variable.widthEquals(value))              \
+  group.access()->base.access()->variable.setWidth(value)
+
 namespace blink {
 
 using std::max;
 
 class FilterOperations;
 
 class AppliedTextDecoration;
 class BorderData;
 struct BorderEdge;
 class CSSAnimationData;
@@ skipping 488 matching lines @@
   }
   void setBorderImageWidth(const BorderImageLengthBox&);
 
   // border-image-outset
   const BorderImageLengthBox& borderImageOutset() const {
     return m_surround->border.image().outset();
   }
   void setBorderImageOutset(const BorderImageLengthBox&);
 
   // Border width properties.
-  static unsigned initialBorderWidth() { return 3; }
+  static float initialBorderWidth() { return 3; }
 
   // border-top-width
-  int borderTopWidth() const { return m_surround->border.borderTopWidth(); }
-  void setBorderTopWidth(unsigned v) {
-    SET_VAR(m_surround, border.m_top.m_width, v);
+  float borderTopWidth() const { return m_surround->border.borderTopWidth(); }
+  void setBorderTopWidth(float v) {
+    SET_BORDER_WIDTH(m_surround, border.m_top, v);
   }
 
   // border-bottom-width
-  int borderBottomWidth() const {
+  float borderBottomWidth() const {
     return m_surround->border.borderBottomWidth();
   }
-  void setBorderBottomWidth(unsigned v) {
-    SET_VAR(m_surround, border.m_bottom.m_width, v);
+  void setBorderBottomWidth(float v) {
+    SET_BORDER_WIDTH(m_surround, border.m_bottom, v);
   }
 
   // border-left-width
-  int borderLeftWidth() const { return m_surround->border.borderLeftWidth(); }
-  void setBorderLeftWidth(unsigned v) {
-    SET_VAR(m_surround, border.m_left.m_width, v);
+  float borderLeftWidth() const { return m_surround->border.borderLeftWidth(); }
+  void setBorderLeftWidth(float v) {
+    SET_BORDER_WIDTH(m_surround, border.m_left, v);
   }
 
   // border-right-width
-  int borderRightWidth() const { return m_surround->border.borderRightWidth(); }
-  void setBorderRightWidth(unsigned v) {
-    SET_VAR(m_surround, border.m_right.m_width, v);
+  float borderRightWidth() const {
+    return m_surround->border.borderRightWidth();
+  }
+  void setBorderRightWidth(float v) {
+    SET_BORDER_WIDTH(m_surround, border.m_right, v);
   }
 
   // Border style properties.
   static EBorderStyle initialBorderStyle() { return BorderStyleNone; }
 
   // border-top-style
   EBorderStyle borderTopStyle() const {
     return m_surround->border.top().style();
   }
   void setBorderTopStyle(EBorderStyle v) {
@@ skipping 223 matching lines @@
   void setColumnRuleStyle(EBorderStyle b) {
     SET_NESTED_VAR(m_rareNonInheritedData, m_multiCol, m_rule.m_style, b);
   }
 
   // column-rule-width (aka -webkit-column-rule-width)
   static unsigned short initialColumnRuleWidth() { return 3; }
   unsigned short columnRuleWidth() const {
     return m_rareNonInheritedData->m_multiCol->ruleWidth();
   }
   void setColumnRuleWidth(unsigned short w) {
-    SET_NESTED_VAR(m_rareNonInheritedData, m_multiCol, m_rule.m_width, w);
+    SET_NESTED_BORDER_WIDTH(m_rareNonInheritedData, m_multiCol, m_rule, w);
   }
 
   // column-span (aka -webkit-column-span)
   static ColumnSpan initialColumnSpan() { return ColumnSpanNone; }
   ColumnSpan getColumnSpan() const {
     return static_cast<ColumnSpan>(
         m_rareNonInheritedData->m_multiCol->m_columnSpan);
   }
   void setColumnSpan(ColumnSpan columnSpan) {
     SET_NESTED_VAR(m_rareNonInheritedData, m_multiCol, m_columnSpan,
@@ skipping 555 matching lines @@
   OutlineIsAuto outlineStyleIsAuto() const {
     return static_cast<OutlineIsAuto>(
         m_rareNonInheritedData->m_outline.isAuto());
   }
   void setOutlineStyleIsAuto(OutlineIsAuto isAuto) {
     SET_VAR(m_rareNonInheritedData, m_outline.m_isAuto, isAuto);
   }
 
   // outline-width
   static unsigned short initialOutlineWidth() { return 3; }
-  int outlineWidth() const {
+  unsigned short outlineWidth() const {
     if (m_rareNonInheritedData->m_outline.style() == BorderStyleNone)
       return 0;
     return m_rareNonInheritedData->m_outline.width();
   }
   void setOutlineWidth(unsigned short v) {
-    SET_VAR(m_rareNonInheritedData, m_outline.m_width, v);
+    SET_BORDER_WIDTH(m_rareNonInheritedData, m_outline, v);
   }
 
   // outline-offset
   static int initialOutlineOffset() { return 0; }
   int outlineOffset() const {
     if (m_rareNonInheritedData->m_outline.style() == BorderStyleNone)
       return 0;
     return m_rareNonInheritedData->m_outline.offset();
   }
   void setOutlineOffset(int v) {
@@ skipping 1698 matching lines @@
   const BorderValue& borderLeft() const { return m_surround->border.left(); }
   const BorderValue& borderRight() const { return m_surround->border.right(); }
   const BorderValue& borderTop() const { return m_surround->border.top(); }
   const BorderValue& borderBottom() const {
     return m_surround->border.bottom();
   }
   const BorderValue& borderBefore() const;
   const BorderValue& borderAfter() const;
   const BorderValue& borderStart() const;
   const BorderValue& borderEnd() const;
-  int borderAfterWidth() const;
-  int borderBeforeWidth() const;
-  int borderEndWidth() const;
-  int borderStartWidth() const;
-  int borderOverWidth() const;
-  int borderUnderWidth() const;
+  float borderAfterWidth() const;
+  float borderBeforeWidth() const;
+  float borderEndWidth() const;
+  float borderStartWidth() const;
+  float borderOverWidth() const;
+  float borderUnderWidth() const;
 
   bool hasBorderFill() const { return m_surround->border.hasBorderFill(); }
   bool hasBorder() const { return m_surround->border.hasBorder(); }
   bool hasBorderDecoration() const { return hasBorder() || hasBorderFill(); }
   bool hasBorderRadius() const { return m_surround->border.hasBorderRadius(); }
 
   void resetBorder() {
     resetBorderImage();
     resetBorderTop();
     resetBorderRight();
@@ skipping 744 matching lines @@
   m_nonInheritedData.m_pseudoBits |= 1 << (pseudo - 1);
 }
 
 inline bool ComputedStyle::hasPseudoElementStyle() const {
   return m_nonInheritedData.m_pseudoBits & ElementPseudoIdMask;
 }
 
 }  // namespace blink
 
 #endif  // ComputedStyle_h