xfa/fde/xml/fde_xml_imp.cpp - Issue 2640143003: Update safe numerics package to get bitwise ops

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fde/xml/fde_xml_imp.cpp

Issue 2640143003: Update safe numerics package to get bitwise ops (Closed)

Patch Set: 0 is a perfectly fine value of zero Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fde/xml/fde_xml_imp.cpp

diff --git a/xfa/fde/xml/fde_xml_imp.cpp b/xfa/fde/xml/fde_xml_imp.cpp

index 2bdaf5155fa9ac5c5147d2f49fdf02c711a60cd0..5adaa5c86fc310aca303295e4659cccf6c50e2c7 100644

--- a/xfa/fde/xml/fde_xml_imp.cpp

+++ b/xfa/fde/xml/fde_xml_imp.cpp

@@ -1314,7 +1314,7 @@ void CFDE_XMLSyntaxParser::Init(const CFX_RetainPtr<IFGAS_Stream>& pStream,

return;

}

- m_pBuffer = FX_Alloc(FX_WCHAR, alloc_size_safe.ValueOrDie());

+ m_pBuffer = FX_Alloc(FX_WCHAR, alloc_size_safe.ValueOrDie<size_t>());

m_pStart = m_pEnd = m_pBuffer;

ASSERT(!m_BlockBuffer.IsInitialized());

m_BlockBuffer.InitBuffer();