content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ChildProcessLauncherTestHelperService.java - Issue 2640143002: Allow autoplay unmuted for WebAPK in the manifest scope

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ChildProcessLauncherTestHelperService.java

Issue 2640143002: Allow autoplay unmuted for WebAPK in the manifest scope (Closed)

Patch Set: addressed mlamouri's comments & cl format Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/android/java/src/org/chromium/content/app/ChildProcessServiceImpl.java ('K') | « content/renderer/render_view_impl.cc ('k') | third_party/WebKit/LayoutTests/media/autoplay-non-whitelisted-scope.html » ('j') | third_party/WebKit/Source/core/html/HTMLMediaElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ChildProcessLauncherTestHelperService.java

diff --git a/content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ChildProcessLauncherTestHelperService.java b/content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ChildProcessLauncherTestHelperService.java

index 9da9eb38c4eedc4627cdef68046a71ae789c63bb..32f0d7c789108daacafcea0db2fc9e7a9537a29d 100644

--- a/content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ChildProcessLauncherTestHelperService.java

+++ b/content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ChildProcessLauncherTestHelperService.java

@@ -68,8 +68,8 @@ public class ChildProcessLauncherTestHelperService extends Service {

private void doBindService(final Message msg) {

String[] commandLine = { "_", "--" + BaseSwitches.RENDERER_WAIT_FOR_JAVA_DEBUGGER };

- ChildProcessCreationParams params = new ChildProcessCreationParams(getPackageName(), false,

- LibraryProcessType.PROCESS_CHILD);

+ ChildProcessCreationParams params = new ChildProcessCreationParams(

+ getPackageName(), false, LibraryProcessType.PROCESS_CHILD, null);

final ChildProcessConnection conn = ChildProcessLauncher.startForTesting(this, commandLine,

new FileDescriptorInfo[0], params);