Allow autoplay unmuted for WebAPK in the manifest scope

third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

 /*
  * Copyright (C) 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights
  * reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 275 matching lines @@
 
   NOTREACHED();
   return String();
 }
 
 bool isDocumentCrossOrigin(Document& document) {
   const LocalFrame* frame = document.frame();
   return frame && frame->isCrossOriginSubframe();
 }
 
+bool isDocumentWhitelisted(Document& document, const String& whitelistScope) {
+  if (whitelistScope.isNull() || whitelistScope.isEmpty())
+    return false;
+  if (whitelistScope == "*")
+    return true;

[mlamouri (slow - plz ping), 2017/02/10 14:28:46]

How can that happen?

[Zhiqiang Zhang (Slow), 2017/02/10 14:47:11]

Ah, I was thinking of when the manifest is unscoped. However actually WebAPK
trims the start_url for the scope if the manifest is unscoped. That says WebAPKs
are always scoped.

+
+  return document.url().getString().startsWith(whitelistScope);
+}
+
 // Return true if and only if the document settings specifies media playback
 // requires user gesture.
 bool computeLockedPendingUserGesture(Document& document) {
   if (!document.settings())
     return false;
 
+  if (isDocumentWhitelisted(
+          document,
+          document.settings()->getMediaPlaybackGestureWhitelistScope())) {

[mlamouri (slow - plz ping), 2017/02/10 14:28:46]

I guess you could just pass `document` and get the settings from the document
inside the method? You could even add an DCHECK() that the settings is
available.

[Zhiqiang Zhang (Slow), 2017/02/10 14:47:11]

Done.

+    return false;
+  }
+
   if (document.settings()->getCrossOriginMediaPlaybackRequiresUserGesture() &&
       isDocumentCrossOrigin(document)) {
     return true;
   }
 
   return document.settings()->getMediaPlaybackRequiresUserGesture();
 }
 
 }  // anonymous namespace
 
@@ skipping 3814 matching lines @@
       kMostlyFillViewportBecomeStableSeconds, BLINK_FROM_HERE);
 }
 
 void HTMLMediaElement::viewportFillDebouncerTimerFired(TimerBase*) {
   m_mostlyFillingViewport = true;
   if (m_webMediaPlayer)
     m_webMediaPlayer->becameDominantVisibleContent(m_mostlyFillingViewport);
 }
 
 }  // namespace blink