third_party/WebKit/Source/bindings/scripts/v8_attributes.py - Issue 2640123006: Use the current context as the creation context for cross-origin objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_attributes.py

Issue 2640123006: Use the current context as the creation context for cross-origin objects. (Closed)

Patch Set: Add comment Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/scripts/v8_attributes.py

diff --git a/third_party/WebKit/Source/bindings/scripts/v8_attributes.py b/third_party/WebKit/Source/bindings/scripts/v8_attributes.py

index 7e24cc05bbbe2ae89ad628e426080051e9702e94..4ff2d5107f7ccf66eebd38071e6db183f96fceba 100644

--- a/third_party/WebKit/Source/bindings/scripts/v8_attributes.py

+++ b/third_party/WebKit/Source/bindings/scripts/v8_attributes.py

@@ -198,8 +198,6 @@ def attribute_context(interface, attribute, interfaces):

# [CrossOrigin] is incompatible with a number of other attributes, so check

# for them here.

if is_cross_origin:

- if context['has_cross_origin_getter'] and context['has_custom_getter']:

- raise Exception('[CrossOrigin] and [Custom] are incompatible on the same getter: %s.%s', interface.name, attribute.name)

if context['has_cross_origin_setter'] and context['has_custom_setter']:

raise Exception('[CrossOrigin] and [Custom] are incompatible on the same setter: %s.%s', interface.name, attribute.name)

if context['is_per_world_bindings']: