Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: src/wasm/wasm-result.cc

Issue 2640113005: [wasm] W.validate should not throw on failure (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/wasm/wasm-result.h ('K') | « src/wasm/wasm-result.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/wasm/wasm-result.cc
diff --git a/src/wasm/wasm-result.cc b/src/wasm/wasm-result.cc
index 99111c6a5489c04f8646d600779e35ce3c3b925e..e22f9ad4428bf6d1061b393c7deff6770b53cb37 100644
--- a/src/wasm/wasm-result.cc
+++ b/src/wasm/wasm-result.cc
@@ -64,6 +64,7 @@ void ErrorThrower::RangeError(const char* format, ...) {
void ErrorThrower::CompileError(const char* format, ...) {
if (error()) return;
+ wasm_error_ = true;
va_list arguments;
va_start(arguments, format);
Format(isolate_->wasm_compile_error_function(), format, arguments);
@@ -72,6 +73,7 @@ void ErrorThrower::CompileError(const char* format, ...) {
void ErrorThrower::LinkError(const char* format, ...) {
if (error()) return;
+ wasm_error_ = true;
va_list arguments;
va_start(arguments, format);
Format(isolate_->wasm_link_error_function(), format, arguments);
@@ -80,6 +82,7 @@ void ErrorThrower::LinkError(const char* format, ...) {
void ErrorThrower::RuntimeError(const char* format, ...) {
if (error()) return;
+ wasm_error_ = true;
va_list arguments;
va_start(arguments, format);
Format(isolate_->wasm_runtime_error_function(), format, arguments);
« src/wasm/wasm-result.h ('K') | « src/wasm/wasm-result.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698