Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4600)

Unified Diff: chromecast/media/base/media_codec_support.h

Issue 2640113004: Introduce Dolby Vision video codec and Demuxer support (Closed)
Patch Set: fix CQ failure Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/media/base/media_codec_support.h
diff --git a/chromecast/media/base/media_codec_support.h b/chromecast/media/base/media_codec_support.h
index cbbf67ca3e9294c2aec636dce3633a04c9af8dc5..3f6b088e9fff9240582a16af7ed999184906d724 100644
--- a/chromecast/media/base/media_codec_support.h
+++ b/chromecast/media/base/media_codec_support.h
@@ -24,7 +24,15 @@ namespace media {
// representation of the codec id conforming to RFC 6381) is supported or not.
::media::IsCodecSupportedCB GetIsCodecSupportedOnChromecastCB();
-VideoCodec ToCastVideoCodec(const ::media::VideoCodec codec);
+// Converts ::media::VideoCodec to chromecast::media::VideoCodec. Any unknown or
+// unsupported codec will be converted to chromecast::media::kCodecUnknown. Note
+// |codec_profile| is ignored for codecs other than Dolby Vision.
+// TODO(erickung): Removes |codec_profile| parameter by changing VideoCodec enum
wolenetz 2017/02/18 00:01:02 nit: s/Removes/Remove/
erickung1 2017/02/27 17:33:10 Done.
+// to align with ::media::VideoCodecs.
+VideoCodec ToCastVideoCodec(const ::media::VideoCodec codec,
+ const ::media::VideoCodecProfile codec_profile);
+
+// Converts ::media::VideoCodecProfile to chromecast::media::VideoProfile.
VideoProfile ToCastVideoProfile(const ::media::VideoCodecProfile profile);
CodecProfileLevel ToCastCodecProfileLevel(
const ::media::CodecProfileLevel& codec_profile_level);

Powered by Google App Engine
This is Rietveld 408576698