Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Unified Diff: media/base/video_codecs_unittest.cc

Issue 2640113004: Introduce Dolby Vision video codec and Demuxer support (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/video_codecs_unittest.cc
diff --git a/media/base/video_codecs_unittest.cc b/media/base/video_codecs_unittest.cc
index 7a78bc5a9b1251841dacb8398bc8abf827a2771b..4c1ca0ae4aa31e5c2b5782444a14cee0184a4c07 100644
--- a/media/base/video_codecs_unittest.cc
+++ b/media/base/video_codecs_unittest.cc
@@ -148,4 +148,41 @@ TEST(ParseHEVCCodecIdTest, InvalidHEVCCodecIds) {
}
#endif
+#if BUILDFLAG(ENABLE_DOLBY_VISION_DEMUXING)
+TEST(ParseDolbyVisionCodecIdTest, InvalidDolbyVisionCodecIds) {
+ VideoCodecProfile profile = VIDEO_CODEC_PROFILE_UNKNOWN;
+ uint8_t level_id = 0;
+
+ EXPECT_TRUE(ParseDolbyVisionCodecId("dvav.05.07", &profile, &level_id));
+ EXPECT_EQ(profile, DOLBYVISION_PROFILE5);
+ EXPECT_EQ(level_id, 7);
+ EXPECT_TRUE(ParseDolbyVisionCodecId("dva1.05.07", &profile, &level_id));
+ EXPECT_EQ(profile, DOLBYVISION_PROFILE5);
+ EXPECT_EQ(level_id, 7);
+ EXPECT_TRUE(ParseDolbyVisionCodecId("dvhe.05.07", &profile, &level_id));
+ EXPECT_EQ(profile, DOLBYVISION_PROFILE5);
+ EXPECT_EQ(level_id, 7);
+ EXPECT_TRUE(ParseDolbyVisionCodecId("dvh1.05.07", &profile, &level_id));
wolenetz 2017/01/25 23:42:41 nit: supported format includes those without a lea
erickung1 2017/02/03 18:18:31 according to Dolby Vision spec, the profile and le
+ EXPECT_EQ(profile, DOLBYVISION_PROFILE5);
+ EXPECT_EQ(level_id, 7);
+
+ EXPECT_FALSE(ParseDolbyVisionCodecId("dvav", &profile, &level_id));
+ EXPECT_FALSE(ParseDolbyVisionCodecId("dvav.", &profile, &level_id));
+ EXPECT_FALSE(ParseDolbyVisionCodecId("dvav..", &profile, &level_id));
+ EXPECT_FALSE(ParseDolbyVisionCodecId("dvav...", &profile, &level_id));
+ EXPECT_FALSE(ParseDolbyVisionCodecId("dvav....", &profile, &level_id));
+ EXPECT_FALSE(ParseDolbyVisionCodecId("dvav.1", &profile, &level_id));
+ EXPECT_FALSE(ParseDolbyVisionCodecId("dvav.1.", &profile, &level_id));
+ EXPECT_FALSE(ParseDolbyVisionCodecId("dvav.1..", &profile, &level_id));
+ EXPECT_FALSE(ParseDolbyVisionCodecId("dvav.1...", &profile, &level_id));
+ EXPECT_FALSE(ParseDolbyVisionCodecId("dvav.1.6.", &profile, &level_id));
+ EXPECT_FALSE(ParseDolbyVisionCodecId("dvav.1.6..", &profile, &level_id));
+ EXPECT_FALSE(ParseDolbyVisionCodecId("dvav.1.6...", &profile, &level_id));
+
+ EXPECT_FALSE(ParseDolbyVisionCodecId("dvav..", &profile, &level_id));
+ EXPECT_FALSE(ParseDolbyVisionCodecId("dvav.1.", &profile, &level_id));
+ EXPECT_FALSE(ParseDolbyVisionCodecId("dvav..1", &profile, &level_id));
+}
+#endif
+
} // namespace media

Powered by Google App Engine
This is Rietveld 408576698