Introduce Dolby Vision video codec and Demuxer support

chromecast/media/base/media_codec_support.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromecast/media/base/media_codec_support.h"
 
 #include "base/bind.h"
 #include "base/strings/string_util.h"
 #include "chromecast/media/base/media_caps.h"
 #include "chromecast/public/media_codec_support_shlib.h"
@@ skipping 17 matching lines @@
 
   if (codec == "aac51") {
     return MediaCapabilities::HdmiSinkSupportsPcmSurroundSound();
   }
   if (codec == "ac-3" || codec == "mp4a.a5" || codec == "mp4a.A5") {
     return MediaCapabilities::HdmiSinkSupportsAC3();
   }
   if (codec == "ec-3" || codec == "mp4a.a6" || codec == "mp4a.A6") {
     return MediaCapabilities::HdmiSinkSupportsEAC3();
   }
+  // Shared library should return kDefault if the platform depends on sink

[wolenetz, 2017/01/24 21:52:23]

Is kDefault a bool? Or am I confused by this comment by assuming
MediaCapabilities::HdmiSinkSupportsDolbyVision() is the method in the shared lib
that the comment is referencing? Either way, fix or clarify better please.

[erickung1, 2017/02/03 18:18:30]

Done.

+  // device capability to stream Dolby Vision.
+  if (base::StartsWith(codec, "dvav.", base::CompareCase::SENSITIVE) ||
+      base::StartsWith(codec, "dvhe.", base::CompareCase::SENSITIVE)) {
+    return MediaCapabilities::HdmiSinkSupportsDolbyVision();
+  }
 
   // This function is invoked from MimeUtil::AreSupportedCodecs to check if a
   // given codec id is supported by Chromecast or not. So by default we should
   // return true by default to indicate we have no reasons to believe this codec
   // is unsupported. This will allow the rest of MimeUtil checks to proceed as
   // usual.
   return true;
 }
 
 }  // namespace
 
 ::media::IsCodecSupportedCB GetIsCodecSupportedOnChromecastCB() {
   return base::Bind(&IsCodecSupported);
 }
 
 // Converts ::media::VideoCodec to chromecast::media::VideoCodec. Any unknown or

[wolenetz, 2017/01/24 21:52:24]

comments like this belong in .h instead of .cc
Also, please commnet that |codec_profile| is ignored for codecs other than DV.
Or perform the appropriate checking of |codec_profile| for non-DV codecs.

[erickung1, 2017/02/03 18:18:30]

Done.

 // unsupported codec will be converted to chromecast::media::kCodecUnknown.
-VideoCodec ToCastVideoCodec(const ::media::VideoCodec video_codec) {
+VideoCodec ToCastVideoCodec(const ::media::VideoCodec video_codec,
+                            const ::media::VideoCodecProfile codec_profile) {
   switch (video_codec) {
     case ::media::kCodecH264:
       return kCodecH264;
     case ::media::kCodecVP8:
       return kCodecVP8;
     case ::media::kCodecVP9:
       return kCodecVP9;
     case ::media::kCodecHEVC:
       return kCodecHEVC;
+    case ::media::kCodecDolbyVision:
+      if (codec_profile == ::media::DOLBYVISION_PROFILE0)

[wolenetz, 2017/01/24 21:52:24]

I'm unfamiliar with DV profiles, but compared to previous CL
(https://codereview.chromium.org/2541743002/diff/100001/chromecast/media/base/...),
this code doesn't recognize PROFILE1 or PROFILE2 as DVH264. Is that intentional?

[erickung1, 2017/02/03 18:18:30]

Yes, for the latest DV spec from Dolby, profile 1 2 3 and 6 will be deprecated.

profile 0 and 1 are encoded using H264

+        return kCodecDolbyVisionH264;
+      else if (codec_profile == ::media::DOLBYVISION_PROFILE4 ||

[wolenetz, 2017/01/24 21:52:24]

Ditto: is omission of check for DV profiles 3 and 6 here intentional versus the
previous CL
(https://codereview.chromium.org/2541743002/diff/100001/chromecast/media/base/...)
?

[erickung1, 2017/02/03 18:18:31]

ditto, the profile 3 and 6 will deprecated.

+               codec_profile == ::media::DOLBYVISION_PROFILE5 ||
+               codec_profile == ::media::DOLBYVISION_PROFILE7)

[halliwell, 2017/01/20 02:05:04]

nit, prefer braces { } for multi-line conditions

[wolenetz, 2017/01/24 21:52:23]

Chromium definitely needs { } here.

[erickung1, 2017/02/03 18:18:31]

Done.

+        return kCodecDolbyVisionHEVC;
+      LOG(ERROR) << "Unsupported video codec profile " << codec_profile;
+      break;
     default:
       LOG(ERROR) << "Unsupported video codec " << video_codec;
   }
   return kVideoCodecUnknown;
 }
 
 // Converts ::media::VideoCodecProfile to chromecast::media::VideoProfile.

[wolenetz, 2017/01/24 21:52:24]

nit ditto: move comment to .h

[erickung1, 2017/02/03 18:18:30]

Done.

 VideoProfile ToCastVideoProfile(
     const ::media::VideoCodecProfile codec_profile) {
   switch (codec_profile) {
     case ::media::H264PROFILE_BASELINE:
       return kH264Baseline;
     case ::media::H264PROFILE_MAIN:
       return kH264Main;
     case ::media::H264PROFILE_EXTENDED:
       return kH264Extended;
     case ::media::H264PROFILE_HIGH:
@@ skipping 21 matching lines @@
     case ::media::VP8PROFILE_ANY:
       return kVP8ProfileAny;
     case ::media::VP9PROFILE_PROFILE0:
       return kVP9Profile0;
     case ::media::VP9PROFILE_PROFILE1:
       return kVP9Profile1;
     case ::media::VP9PROFILE_PROFILE2:
       return kVP9Profile2;
     case ::media::VP9PROFILE_PROFILE3:
       return kVP9Profile3;
+    case ::media::DOLBYVISION_PROFILE0:

[wolenetz, 2017/01/24 21:52:24]

(Ditto of above query about intentionality of omission of other profiles that
were in the previous CL, here and elsewhere.)

[erickung1, 2017/02/03 18:18:30]

as mentioned above, profile 1 2 3 and 6 are deprecated by Dolby. we don't want
to define deprecated profile enum value in the chromium code

+      return kDolbyVisionCompatible_EL_MD;
+    case ::media::DOLBYVISION_PROFILE4:
+      return kDolbyVisionCompatible_EL_MD;
+    case ::media::DOLBYVISION_PROFILE5:
+      return kDolbyVisionNonCompatible_BL_MD;
+    case ::media::DOLBYVISION_PROFILE7:
+      return kDolbyVisionNonCompatible_BL_EL_MD;
     default:
       LOG(INFO) << "Unsupported video codec profile " << codec_profile;
   }
   return kVideoProfileUnknown;
 }
 
 }  // namespace media
 }  // namespace chromecast