Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1997)

Issue 2640093005: Buildbot: Change --copy-crashdumps to do the actual archiving to CloudStorage. (Closed)

Created:
3 years, 11 months ago by Vyacheslav Egorov (Google)
Modified:
3 years, 11 months ago
Reviewers:
kustermann
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Buildbot: Change --copy-crashdumps to do the actual archiving to CloudStorage. This flag now both enables core dump collection by setting appropriate rlimits and takes care of archiving cores and crashed binaries. R=kustermann@google.com Committed: https://github.com/dart-lang/sdk/commit/6c9ca0cd2bedb8ab2ad889ccd61784e6695ea0a6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -18 lines) Patch
M tools/test.py View 1 chunk +3 lines, -1 line 0 comments Download
M tools/testing/dart/test_progress.dart View 1 chunk +23 lines, -16 lines 0 comments Download
M tools/utils.py View 2 chunks +135 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Vyacheslav Egorov (Google)
3 years, 11 months ago (2017-01-19 16:23:31 UTC) #1
kustermann
lgtm
3 years, 11 months ago (2017-01-19 16:25:09 UTC) #2
Vyacheslav Egorov (Google)
3 years, 11 months ago (2017-01-19 16:25:44 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6c9ca0cd2bedb8ab2ad889ccd61784e6695ea0a6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698