bluetooth: Add descriptor list to DeviceDetailsPage on internals page.

chrome/browser/resources/bluetooth_internals/descriptor_list.js

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+/**
+ * Javascript for DescriptorList and DescriptorListItem, served from
+ *     chrome://bluetooth-internals/.
+ */
+
+cr.define('descriptor_list', function() {
+  /** @const */ var ArrayDataModel = cr.ui.ArrayDataModel;
+  /** @const */ var ExpandableList = expandable_list.ExpandableList;
+  /** @const */ var ExpandableListItem = expandable_list.ExpandableListItem;
+  /** @const */ var Snackbar = snackbar.Snackbar;
+  /** @const */ var SnackbarType = snackbar.SnackbarType;
+
+  /** Property names for the DescriptorInfo fieldset */
+  var INFO_PROPERTY_NAMES = {
+    id: 'ID',
+    'uuid.uuid': 'UUID',
+  };
+
+  /**
+   * A list item that displays the properties of a DescriptorInfo object.
+   * A fieldset is created within the element for the primitive
+   * properties, 'id' and 'uuid' within the DescriptorInfo object.
+   * @constructor
+   * @param {!interfaces.BluetoothDevice.DescriptorInfo} descriptorInfo
+   */
+  function DescriptorListItem(descriptorInfo) {
+    var listItem = new ExpandableListItem();
+    listItem.__proto__ = DescriptorListItem.prototype;
+
+    listItem.info = descriptorInfo;
+    listItem.decorate();
+
+    return listItem;
+  }
+
+  DescriptorListItem.prototype = {
+    __proto__: ExpandableListItem.prototype,
+
+    /**
+     * Decorates the element as a descriptor list item. Creates and caches
+     * a fieldset for displaying property values.
+     * @override
+     */
+    decorate: function() {
+      this.classList.add('descriptor-list-item');
+
+      /** @private {!object_fieldset.ObjectFieldSet} */
+      this.descriptorFieldSet_ = object_fieldset.ObjectFieldSet();
+      this.descriptorFieldSet_.setPropertyDisplayNames(INFO_PROPERTY_NAMES);
+      this.descriptorFieldSet_.setObject({
+        id: this.info.id,
+        'uuid.uuid': this.info.uuid.uuid,
+      });
+
+      // Create content for display in brief content container.
+      var descriptorHeaderText = document.createElement('div');
+      descriptorHeaderText.textContent = 'Descriptor:';
+
+      var descriptorHeaderValue = document.createElement('div');
+      descriptorHeaderValue.textContent = this.info.uuid.uuid;
+
+      var descriptorHeader = document.createElement('div');
+      descriptorHeader.appendChild(descriptorHeaderText);
+      descriptorHeader.appendChild(descriptorHeaderValue);
+      this.briefContent_.appendChild(descriptorHeader);
+
+      // Create content for display in expanded content container.
+      var descriptorInfoHeader = document.createElement('h4');
+      descriptorInfoHeader.textContent = 'Descriptor Info';
+
+      var descriptorDiv = document.createElement('div');
+      descriptorDiv.classList.add('flex');
+      descriptorDiv.appendChild(this.descriptorFieldSet_);
+
+      var infoDiv = document.createElement('div');
+      infoDiv.classList.add('info-container');
+      infoDiv.appendChild(descriptorInfoHeader);
+      infoDiv.appendChild(descriptorDiv);
+
+      this.expandedContent_.appendChild(infoDiv);
+    },
+  };
+
+  /**
+   * A list that displays DescriptorListItems.
+   * @constructor
+   */
+  var DescriptorList = cr.ui.define('list');
+
+  DescriptorList.prototype = {
+    __proto__: ExpandableList.prototype,
+
+    /** @override */
+    decorate: function() {
+      ExpandableList.prototype.decorate.call(this);
+
+      /** @private {boolean} */
+      this.descriptorsRequested_ = false;
+
+      this.classList.add('descriptor-list');
+      this.setEmptyMessage('No Descriptors Found');
+    },
+
+    /** @override */
+    createItem: function(data) {
+      return new DescriptorListItem(data);
+    },
+
+    /**
+     * Loads the descriptor list with an array of DescriptorInfo from
+     * the device with |deviceAddress|, service with |serviceId|, and
+     * characteristic with |characteristicId|. If no active connection to the
+     * device exists, one is created.
+     * @param {string} deviceAddress
+     * @param {string} serviceId
+     * @param {string} characteristicId
+     */
+    load: function(deviceAddress, serviceId, characteristicId) {
+      if (this.descriptorsRequested_ || !this.isLoading())

[Dan Beam, 2017/01/24 06:07:29]

it's kinda confusing to call load() and return if !isLoading()...

i'd expect

load: function() {
  if (isLoading())
    return;
},

can we maybe change isLoading to isSpinnerShowing()?

[mbrunson, 2017/01/24 21:29:46]

Done.

+        return;
+
+      this.descriptorsRequested_ = true;
+
+      device_broker.connectToDevice(deviceAddress).then(function(device) {
+        return device.getDescriptors(serviceId, characteristicId);
+      }.bind(this)).then(function(response) {
+        this.setData(new ArrayDataModel(response.descriptors || []));
+        this.setLoading(false);
+        this.descriptorsRequested_ = false;
+      }.bind(this)).catch(function(error) {
+        this.descriptorsRequested_ = false;
+        Snackbar.show(
+            deviceAddress + ': ' + error.message, SnackbarType.ERROR, 'Retry',
+            function() {
+              this.load(deviceAddress, serviceId, characteristicId);
+            }.bind(this));
+      }.bind(this));
+    },
+  };
+
+  return {
+    DescriptorList: DescriptorList,
+    DescriptorListItem: DescriptorListItem,
+  };
+});