third_party/WebKit/LayoutTests/paint/inline/floating-inline.html - Issue 2640053004: Fix compositingContainer for stacked inlines.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/paint/inline/floating-inline.html

Issue 2640053004: Fix compositingContainer for stacked inlines. (Closed)

Patch Set: none Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <div style="overflow: hidden;">

	3 <div style="transform: translate3d(0,0,0); position: relative; width: 400px; height: 400px;">

	4 </div>

	5 </div>

	6 <div style="overflow: hidden; position: relative;">

	7 <div style="display: inline;">

	8 <div style="position: relative; width: 100%; float: right; background: light blue; transform: translate3d(0,0,0)">

	9 test

	10 </div>

	11 </div>

	12 </div>
	Xianzhu 2017/01/20 00:52:14 There are failures on win and mac bots. Can you c There are failures on win and mac bots. Can you convert this test into a ref test? chrishtr 2017/01/20 17:43:02 I think this will be hard to do because of the flo Show quoted text On 2017/01/20 at 00:52:14, Xianzhu wrote: > There are failures on win and mac bots. > > Can you convert this test into a ref test? I think this will be hard to do because of the floating element. Xianzhu 2017/01/20 17:44:46 Can it be like https://cs.chromium.org/chromium/sr Show quoted text On 2017/01/20 17:43:02, chrishtr wrote: > On 2017/01/20 at 00:52:14, Xianzhu wrote: > > There are failures on win and mac bots. > > > > Can you convert this test into a ref test? > > I think this will be hard to do because of the floating element. Can it be like https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/paint/inv... and https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/paint/inv... chrishtr 2017/01/20 18:00:17 Ah yes, good point. I forgot that a float under an Show quoted text On 2017/01/20 at 17:44:46, Xianzhu wrote: > On 2017/01/20 17:43:02, chrishtr wrote: > > On 2017/01/20 at 00:52:14, Xianzhu wrote: > > > There are failures on win and mac bots. > > > > > > Can you convert this test into a ref test? > > > > I think this will be hard to do because of the floating element. > > Can it be like https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/paint/inv... and https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/paint/inv... Ah yes, good point. I forgot that a float under an inline paints like the inline wasn't there. Done.
OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/paint/inline/floating-inline-expected.png » ('j') | no next file with comments »