Convert AutoBlocker static class to KeyedService.

chrome/browser/permissions/permission_blacklist_client.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/permissions/permission_blacklist_client.h"
 
 #include <set>
 #include <string>
 
 #include "base/logging.h"
@@ skipping 56 matching lines @@
 void PermissionBlacklistClient::OnCheckApiBlacklistUrlResult(
     const GURL& url,
     const safe_browsing::ThreatMetadata& metadata) {
   DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
 
   if (timer_->IsRunning())
     timer_->Stop();
   else
     db_manager_->CancelApiCheck(this);
   timer_.reset(nullptr);
+  std::set<content::PermissionType> permission_types;
+  for (const auto& i : metadata.api_permissions) {

[raymes, 2017/01/24 05:15:16]

nit: auto can be helpful sometimes, but in other cases it can be clearer to
specify the full type. In this case I think the type might be clearer (which is
just std::string?). 
(Unfortunately there are no hard rules around this and people lean in different
directions :( )

[meredithl, 2017/01/24 23:20:21]

Done.

+    permission_types.insert(
+        PermissionUtil::ConvertSafeBrowsingNameToPermissionType(i));
+  }
 
-  // TODO(meredithl): Convert the strings returned from Safe Browsing to the
-  // ones used by PermissionUtil for comparison.
   bool permission_blocked =
-      metadata.api_permissions.find(PermissionUtil::GetPermissionString(
-          permission_type_)) != metadata.api_permissions.end();
+      permission_types.find(permission_type_) != permission_types.end();

[raymes, 2017/01/24 05:15:16]

Would this be simpler if we just converted in the other direction?

e.g. bool permission_blocked =
metadata.api_permissions.find(PermissionUtil::PermissionTypeToSafeBrowsingName(permission_type_))
!= metadata.api_permissions.end() ?

[meredithl, 2017/01/24 23:20:21]

Done.

 
   content::BrowserThread::PostTask(
       content::BrowserThread::UI, FROM_HERE,
       base::Bind(&PermissionBlacklistClient::EvaluateBlacklistResultOnUiThread,
                  this, permission_blocked));
 }
 
 void PermissionBlacklistClient::EvaluateBlacklistResultOnUiThread(
     bool permission_blocked) {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
 
   if (is_active_)
     callback_.Run(permission_blocked);
   Release();
 }
 
 void PermissionBlacklistClient::WebContentsDestroyed() {
   is_active_ = false;
   Observe(nullptr);
 }