Convert AutoBlocker static class to KeyedService.

chrome/browser/permissions/permission_util.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/permissions/permission_util.h"
 
 #include "build/build_config.h"
 #include "base/feature_list.h"
 #include "base/logging.h"
 #include "chrome/browser/content_settings/host_content_settings_map_factory.h"
@@ skipping 37 matching lines @@
       return "BackgroundSync";
     case content::PermissionType::FLASH:
       return "Flash";
     case content::PermissionType::NUM:
       break;
   }
   NOTREACHED();
   return std::string();
 }
 
+std::string PermissionUtil::ConvertPermissionTypeToSafeBrowsingName(
+    const content::PermissionType& permission_type) {
+  if (permission_type == content::PermissionType::GEOLOCATION)

[raymes, 2017/01/24 23:44:23]

Please convert this to a switch statement as in GetRequestType below (but
without a default entry). That will ensure that we don't miss any entries. It's
also faster.

[meredithl, 2017/01/25 00:21:10]

Done.

+    return "GEOLOCATION";
+  if (permission_type == content::PermissionType::NOTIFICATIONS)
+    return "NOTIFICATIONS";
+  if (permission_type == content::PermissionType::MIDI_SYSEX)
+    return "MIDI_SYSEX";
+  if (permission_type == content::PermissionType::PUSH_MESSAGING)
+    return "PUSH_MESSAGING";
+  if (permission_type == content::PermissionType::DURABLE_STORAGE)
+    return "DURABLE_STORAGE";
+  if (permission_type == content::PermissionType::PROTECTED_MEDIA_IDENTIFIER)
+    return "PROTECTED_MEDIA_IDENTIFIER";
+  if (permission_type == content::PermissionType::AUDIO_CAPTURE)
+    return "AUDIO_CAPTURE";
+  if (permission_type == content::PermissionType::MIDI)

[raymes, 2017/01/24 23:44:23]

MIDI->VIDEO_CAPTURE

[meredithl, 2017/01/25 00:21:10]

Done.

+    return "VIDEO_CAPTURE";
+  if (permission_type == content::PermissionType::MIDI)
+    return "MIDI";
+  if (permission_type == content::PermissionType::BACKGROUND_SYNC)
+    return "BACKGROUND_SYNC";
+  if (permission_type == content::PermissionType::FLASH)
+    return "FLASH";
+  NOTREACHED();
+  return std::string();
+}
+
 PermissionRequestType PermissionUtil::GetRequestType(
     content::PermissionType type) {
   switch (type) {
     case content::PermissionType::GEOLOCATION:
       return PermissionRequestType::PERMISSION_GEOLOCATION;
     case content::PermissionType::NOTIFICATIONS:
       return PermissionRequestType::PERMISSION_NOTIFICATIONS;
     case content::PermissionType::MIDI_SYSEX:
       return PermissionRequestType::PERMISSION_MIDI_SYSEX;
     case content::PermissionType::PUSH_MESSAGING:
@@ skipping 90 matching lines @@
   ContentSetting final_content_setting = settings_map->GetContentSetting(
       primary_url_, secondary_url_, content_type_, std::string());
   if (final_content_setting != CONTENT_SETTING_ALLOW) {
     PermissionType permission_type;
     if (PermissionUtil::GetPermissionType(content_type_, &permission_type)) {
       PermissionUmaUtil::PermissionRevoked(permission_type, source_ui_,
                                            primary_url_, profile_);
     }
   }
 }