Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: chrome/browser/printing/print_job.cc

Issue 2640033005: Substitute boolean GDI printing for a mode type (Closed)
Patch Set: Fix nits Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/printing/print_job.cc
diff --git a/chrome/browser/printing/print_job.cc b/chrome/browser/printing/print_job.cc
index b00ee4829a53a375dc744e2d803b015a4c737f67..294fcb19718fc58e4529478a7b94bd0eca9f45e0 100644
--- a/chrome/browser/printing/print_job.cc
+++ b/chrome/browser/printing/print_job.cc
@@ -236,10 +236,8 @@ class PrintJob::PdfConversionState {
void Start(const scoped_refptr<base::RefCountedMemory>& data,
const PdfRenderSettings& conversion_settings,
- bool print_text_with_gdi,
const PdfConverter::StartCallback& start_callback) {
- converter_->Start(data, conversion_settings, print_text_with_gdi,
- start_callback);
+ converter_->Start(data, conversion_settings, start_callback);
}
void GetMorePages(const PdfConverter::GetPageCallback& get_page_callback) {
@@ -286,9 +284,12 @@ void PrintJob::StartPdfToEmfConversion(
base::MakeUnique<PdfConversionState>(page_size, content_area,
PdfConverter::CreatePdfToEmfConverter());
const int kPrinterDpi = settings().dpi();
- PdfRenderSettings settings(content_area, kPrinterDpi, true /* autorotate? */);
+ PdfRenderSettings settings(
+ content_area, kPrinterDpi, /*autorotate=*/true,
+ print_text_with_gdi ? PdfRenderSettings::Mode::GDI_TEXT
+ : PdfRenderSettings::Mode::NORMAL);
pdf_conversion_state_->Start(
- bytes, settings, print_text_with_gdi,
+ bytes, settings,
base::Bind(&PrintJob::OnPdfConversionStarted, this));
}
« no previous file with comments | « chrome/browser/printing/pdf_to_emf_converter.cc ('k') | chrome/browser/printing/print_preview_pdf_generated_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698