third_party/WebKit/Source/platform/graphics/AcceleratedStaticBitmapImage.cpp - Issue 2639973002: Add target argument to Copy{Sub}TextureCHROMIUM entry point

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/AcceleratedStaticBitmapImage.cpp

Issue 2639973002: Add target argument to Copy{Sub}TextureCHROMIUM entry point (Closed)

Patch Set: use dest_target instead of target Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« gpu/GLES2/extensions/CHROMIUM/CHROMIUM_copy_texture.txt ('K') | « ppapi/lib/gl/include/GLES2/gl2ext.h ('k') | third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/AcceleratedStaticBitmapImage.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/AcceleratedStaticBitmapImage.cpp b/third_party/WebKit/Source/platform/graphics/AcceleratedStaticBitmapImage.cpp

index 3cb04fe8c4dc6372dd1db8425fadaf6274c24f5b..f6e9171c3753f2424fee058185d8dcbb9aec77a0 100644

--- a/third_party/WebKit/Source/platform/graphics/AcceleratedStaticBitmapImage.cpp

+++ b/third_party/WebKit/Source/platform/graphics/AcceleratedStaticBitmapImage.cpp

@@ -82,8 +82,8 @@ void AcceleratedStaticBitmapImage::copyToTexture(

destGL->WaitSyncTokenCHROMIUM(m_textureHolder->syncToken().GetData());

GLuint sourceTextureId = destGL->CreateAndConsumeTextureCHROMIUM(

GL_TEXTURE_2D, m_textureHolder->mailbox().name);

- destGL->CopyTextureCHROMIUM(sourceTextureId, 0, destTextureId, 0,

- internalFormat, destType, flipY, false, false);

+ destGL->CopyTextureCHROMIUM(sourceTextureId, 0, GL_TEXTURE_2D, destTextureId,

+ 0, internalFormat, destType, flipY, false, false);

// This drops the |destGL| context's reference on our |m_mailbox|, but it's

// still held alive by our SkImage.

destGL->DeleteTextures(1, &sourceTextureId);