Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2042)

Unified Diff: chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SectionListTest.java

Issue 2639933003: [NTP suggestions UI] Track precise count of suggestions seen. (Closed)
Patch Set: Fix rebase #2 Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SectionListTest.java
diff --git a/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SectionListTest.java b/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SectionListTest.java
index 608ddc39d348a2993eaea04fdd7c87eda251bd47..9aaffaca05b7483a105852ab0d8352b38a788990 100644
--- a/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SectionListTest.java
+++ b/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SectionListTest.java
@@ -9,6 +9,7 @@ import static org.junit.Assert.assertThat;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when;
+import static org.chromium.chrome.browser.ntp.cards.ContentSuggestionsTestUtils.bindViewHolders;
import static org.chromium.chrome.browser.ntp.cards.ContentSuggestionsTestUtils.createDummySuggestions;
import static org.chromium.chrome.browser.ntp.cards.ContentSuggestionsTestUtils.registerCategory;
@@ -22,18 +23,14 @@ import org.robolectric.annotation.Config;
import org.chromium.base.Callback;
import org.chromium.base.test.util.Feature;
import org.chromium.chrome.browser.ntp.cards.ContentSuggestionsTestUtils.CategoryInfoBuilder;
-import org.chromium.chrome.browser.ntp.snippets.CategoryInt;
import org.chromium.chrome.browser.ntp.snippets.FakeSuggestionsSource;
import org.chromium.chrome.browser.ntp.snippets.KnownCategories;
-import org.chromium.chrome.browser.ntp.snippets.SectionHeaderViewHolder;
import org.chromium.chrome.browser.ntp.snippets.SnippetArticle;
-import org.chromium.chrome.browser.ntp.snippets.SnippetArticleViewHolder;
import org.chromium.chrome.browser.offlinepages.OfflinePageBridge;
import org.chromium.chrome.browser.suggestions.SuggestionsMetricsReporter;
import org.chromium.chrome.browser.suggestions.SuggestionsUiDelegate;
import org.chromium.testing.local.LocalRobolectricTestRunner;
-import java.util.Collections;
import java.util.List;
/**
@@ -231,32 +228,4 @@ public class SectionListTest {
.getPerSectionRank(),
equalTo(3));
}
-
- private static void bindViewHolders(InnerNode node) {
- bindViewHolders(node, 0, node.getItemCount());
- }
-
- private static void bindViewHolders(InnerNode node, int startIndex, int endIndex) {
- for (int i = startIndex; i < endIndex; ++i) {
- node.onBindViewHolder(
- makeViewHolder(node.getItemViewType(i)), i, Collections.emptyList());
- }
- }
-
- private static NewTabPageViewHolder makeViewHolder(@CategoryInt int viewType) {
- switch (viewType) {
- case ItemViewType.SNIPPET:
- return mock(SnippetArticleViewHolder.class);
- case ItemViewType.HEADER:
- return mock(SectionHeaderViewHolder.class);
- case ItemViewType.STATUS:
- return mock(StatusCardViewHolder.class);
- case ItemViewType.ACTION:
- return mock(ActionItem.ViewHolder.class);
- case ItemViewType.PROGRESS:
- return mock(ProgressViewHolder.class);
- default:
- return mock(NewTabPageViewHolder.class);
- }
- }
}

Powered by Google App Engine
This is Rietveld 408576698