Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2639903004: Use entities.dart and types.dart in kernel impact computation. (Closed)

Created:
3 years, 11 months ago by Johnni Winther
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use entities.dart and types.dart in kernel impact computation. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/31202cd96d45211f523cf45b24427a3084a3ed00

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -27 lines) Patch
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 1 chunk +7 lines, -0 lines 2 comments Download
M pkg/compiler/lib/src/ssa/kernel_impact.dart View 12 chunks +26 lines, -27 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 11 months ago (2017-01-18 15:05:47 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2639903004/diff/1/pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart File pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart (right): https://codereview.chromium.org/2639903004/diff/1/pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart#newcode572 pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart:572: ResolutionInterfaceType getInterfaceType(ir.DartType type) => getDartType(type); long line
3 years, 11 months ago (2017-01-18 19:29:08 UTC) #3
Johnni Winther
https://codereview.chromium.org/2639903004/diff/1/pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart File pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart (right): https://codereview.chromium.org/2639903004/diff/1/pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart#newcode572 pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart:572: ResolutionInterfaceType getInterfaceType(ir.DartType type) => getDartType(type); On 2017/01/18 19:29:08, Siggi ...
3 years, 11 months ago (2017-01-19 12:33:07 UTC) #4
Johnni Winther
3 years, 11 months ago (2017-01-19 12:33:42 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
31202cd96d45211f523cf45b24427a3084a3ed00 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698