Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.cpp

Issue 2639893003: [ES6 modules] Introduce Modulator "module map settings object" (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.cpp b/third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.cpp
index ae873c5690e21dddfc68d97710c5a4de9e01ecd7..bf6826b21d446ee7f3d0d614e9d2b869907ade1b 100644
--- a/third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.cpp
@@ -41,6 +41,7 @@
#include "bindings/core/v8/V8Initializer.h"
#include "bindings/core/v8/V8PrivateProperty.h"
#include "bindings/core/v8/V8Window.h"
+#include "core/dom/Modulator.h"
#include "core/frame/LocalFrame.h"
#include "core/frame/csp/ContentSecurityPolicy.h"
#include "core/html/DocumentNameCollection.h"
@@ -248,6 +249,7 @@ void LocalWindowProxy::updateDocument() {
return;
updateActivityLogger();
+ m_scriptState->perContextData()->clearModulator();
haraken 2017/01/18 06:55:55 Why do you want to clear a modulator here?
kouhei (in TOK) 2017/01/18 07:07:10 Chatted offline. We shouldn't clear a modulator he
updateDocumentProperty();
updateSecurityOrigin(frame()->document()->getSecurityOrigin());
}

Powered by Google App Engine
This is Rietveld 408576698