third_party/WebKit/Source/core/dom/Modulator.cpp - Issue 2639893003: [ES6 modules] Introduce Modulator "module map settings object"

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/dom/Modulator.cpp

Issue 2639893003: [ES6 modules] Introduce Modulator "module map settings object" (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "core/dom/Modulator.h"

	6

	7 #include "bindings/core/v8/ScriptState.h"

	8

	9 namespace blink {

	10

	11 Modulator* Modulator::from(LocalFrame* frame) {

	12 return ScriptState::forMainWorld(frame)->perContextData()->modulator();
	dominicc (has gone to gerrit) 2017/01/18 06:59:01 WDYT about returning nullptr when ScriptState::for WDYT about returning nullptr when ScriptState::forMainWorld is null? Up to you. Depends on how you imagine this being used. kouhei (in TOK) 2017/01/18 07:07:10 Done. Show quoted text On 2017/01/18 06:59:01, dominicc wrote: > WDYT about returning nullptr when ScriptState::forMainWorld is null? Up to you. > Depends on how you imagine this being used. Done.
	13 }

	14

	15 } // namespace blink

OLD	NEW