Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2639883005: Add parser support for covariant parameters (Closed)

Created:
3 years, 11 months ago by Brian Wilkerson
Modified:
3 years, 11 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+616 lines, -69 lines) Patch
M pkg/analyzer/lib/error/error.dart View 3 chunks +6 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/dart/error/syntactic_errors.dart View 3 chunks +31 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/error/codes.dart View 1 chunk +10 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error_verifier.dart View 2 chunks +18 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 21 chunks +103 lines, -32 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 27 chunks +439 lines, -18 lines 0 comments Download
M pkg/front_end/lib/src/scanner/token.dart View 2 chunks +4 lines, -0 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 chunk +5 lines, -19 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 11 months ago (2017-01-19 17:16:09 UTC) #2
scheglov
LGTM
3 years, 11 months ago (2017-01-19 17:20:49 UTC) #3
Brian Wilkerson
3 years, 11 months ago (2017-01-19 17:38:40 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d06a2326f1aeb321b69adaa04acce3b7e772169a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698