Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2639743002: Report StateError if the DartSDK for an AnalysisDriver does not have summary. (Closed)

Created:
3 years, 11 months ago by scheglov
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Report StateError if the DartSDK for an AnalysisDriver does not have summary. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/8d326e9a14eee628b28f390f1608212da4df4aa5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -8 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/abstract_context.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/context_manager_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/search/search_engine2_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/src/dart/analysis/driver.dart View 2 chunks +8 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/resolver_test_case.dart View 3 chunks +12 lines, -5 lines 0 comments Download
M pkg/analyzer/test/src/dart/analysis/base.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/test/src/dart/analysis/driver_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/front_end/lib/src/incremental_resolved_ast_generator_impl.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
3 years, 11 months ago (2017-01-17 22:26:23 UTC) #1
Paul Berry
lgtm
3 years, 11 months ago (2017-01-17 22:34:02 UTC) #2
Brian Wilkerson
lgtm
3 years, 11 months ago (2017-01-17 22:43:17 UTC) #3
scheglov
3 years, 11 months ago (2017-01-18 04:46:07 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8d326e9a14eee628b28f390f1608212da4df4aa5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698