Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Unified Diff: content/browser/frame_host/render_frame_host_delegate.h

Issue 263973003: Move LoadProgressTracker to the browser process. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: tweaks Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_delegate.h
diff --git a/content/browser/frame_host/render_frame_host_delegate.h b/content/browser/frame_host/render_frame_host_delegate.h
index b1a15236a59fea955f2ce8addd79f5272de6919a..99bb29e00d8db543bb9ced96a64cba3745164d20 100644
--- a/content/browser/frame_host/render_frame_host_delegate.h
+++ b/content/browser/frame_host/render_frame_host_delegate.h
@@ -44,17 +44,12 @@ class CONTENT_EXPORT RenderFrameHostDelegate {
// Informs the delegate whenever a RenderFrameHost is deleted.
virtual void RenderFrameDeleted(RenderFrameHost* render_frame_host) {}
- // The top-level RenderFrame began loading a new page. This corresponds to
- // Blink's notion of the throbber starting.
- // |to_different_document| will be true unless the load is a fragment
- // navigation, or triggered by history.pushState/replaceState.
+ // The top-level RenderFrame began loading a new page. The presence of this
+ // function in RenderFrameHostDelegate is a hack to allow the RenderFrameHost
+ // to force a loading spinner to show up; TODO(avi): Remove this.
nasko 2014/05/05 23:51:12 I'm not sure that this is a hack. It seems this is
Avi (use Gerrit) 2014/05/06 00:03:40 It feels unbalanced to me. At points we have to fo
virtual void DidStartLoading(RenderFrameHost* render_frame_host,
bool to_different_document) {}
- // The top-level RenderFrame stopped loading a page. This corresponds to
- // Blink's notion of the throbber stopping.
- virtual void DidStopLoading(RenderFrameHost* render_frame_host) {}
-
// The RenderFrameHost has been swapped out.
virtual void SwappedOut(RenderFrameHost* render_frame_host) {}
« no previous file with comments | « no previous file | content/browser/frame_host/render_frame_host_impl.h » ('j') | content/browser/web_contents/web_contents_impl.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698