Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1073)

Unified Diff: content/renderer/render_view_browsertest.cc

Issue 263973003: Move LoadProgressTracker to the browser process. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: cleanip Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_view_browsertest.cc
diff --git a/content/renderer/render_view_browsertest.cc b/content/renderer/render_view_browsertest.cc
index b06151b93a6c9496d78be4bb62485f7ff2baa79a..f0c5766ab4bc524263e19a8bd3fa754e7952c2c7 100644
--- a/content/renderer/render_view_browsertest.cc
+++ b/content/renderer/render_view_browsertest.cc
@@ -2233,40 +2233,6 @@ TEST_F(RenderViewImplTest, SendFaviconURLUpdateEvent) {
ViewHostMsg_UpdateFaviconURL::ID));
}
-// Test progress tracker messages.
-TEST_F(RenderViewImplTest, SendProgressCompletionUpdates) {
- std::string data_url_string = "data:text/html,<body>placeholder</body>";
- GURL url(data_url_string);
- GetMainFrame()->loadRequest(blink::WebURLRequest(url));
-
- EXPECT_TRUE(render_thread_->sink().GetFirstMessageMatching(
- FrameHostMsg_DidStartLoading::ID));
-
- // The load started, we should receive a start notification and a progress
- // update with the minimum progress.
- const IPC::Message* message = render_thread_->sink().GetFirstMessageMatching(
- ViewHostMsg_DidChangeLoadProgress::ID);
- EXPECT_TRUE(message);
- Tuple1<double> progress_value;
- ViewHostMsg_DidChangeLoadProgress::Read(message, &progress_value);
- EXPECT_EQ(0.1, progress_value.a);
- render_thread_->sink().ClearMessages();
-
- FrameLoadWaiter(frame()).Wait();
-
- // The data url has loaded, so we should see a progress change to 1.0 (done)
- // and a stop notification.
- message = render_thread_->sink().GetFirstMessageMatching(
- ViewHostMsg_DidChangeLoadProgress::ID);
- EXPECT_TRUE(message);
- ViewHostMsg_DidChangeLoadProgress::Read(message, &progress_value);
- EXPECT_EQ(1.0, progress_value.a);
-
- EXPECT_TRUE(render_thread_->sink().GetFirstMessageMatching(
- FrameHostMsg_DidStopLoading::ID));
- render_thread_->sink().ClearMessages();
-}
-
TEST_F(RenderViewImplTest, FocusElementCallsFocusedNodeChanged) {
LoadHTML("<input id='test1' value='hello1'></input>"
"<input id='test2' value='hello2'></input>");

Powered by Google App Engine
This is Rietveld 408576698