third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js - Issue 2639703002: DevTools: Console: Provide autocompletions for Maps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js

Issue 2639703002: DevTools: Console: Provide autocompletions for Maps (Closed)

Patch Set: Add delete Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/components/JavaScriptAutocomplete.js ('K') | « third_party/WebKit/Source/devtools/front_end/components/JavaScriptAutocomplete.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js

diff --git a/third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js b/third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js

index 5351fa7ec4caf519e71075d3f871d2dcdf3b365f..11d9e3305c8cb4b5bfc637d33d9ed7e233fa3bd4 100644

--- a/third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js

+++ b/third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js

@@ -264,7 +264,7 @@ Console.ConsolePrompt = class extends UI.Widget {

var excludedTokens = new Set(['js-comment', 'js-string-2', 'js-def']);

var trimmedBefore = before.trim();

- if (!trimmedBefore.endsWith('['))

+ if (!trimmedBefore.endsWith('[') && !trimmedBefore.match(/\.\s*(get|set|delete)\s*\(\s*$/))

excludedTokens.add('js-string');

if (!trimmedBefore.endsWith('.'))

excludedTokens.add('js-property');