VM: Fix umulh on simarm64 Windows.

VM: Fix umulh on simarm64 Windows.

Also add correct suffix for uint64_t in another place.

BUG=
R=zra@google.com

Committed: https://github.com/dart-lang/sdk/commit/13383d7f85b96b75d2c190b4dabf05fe0b653165

[Florian Schneider, 2017-01-17 20:11:12]

fschneider@google.com changed reviewers:
+ zra@google.com

[zra, 2017-01-17 20:18:05]

lgtm with question

https://codereview.chromium.org/2639693002/diff/1/runtime/vm/simulator_arm64.cc
File runtime/vm/simulator_arm64.cc (right):

https://codereview.chromium.org/2639693002/diff/1/runtime/vm/simulator_arm64....
runtime/vm/simulator_arm64.cc:2681: static_cast<__int128>(rn_val) *
static_cast<__int128>(rm_val);
Is this one signed or unsigned?

[Florian Schneider, 2017-01-17 21:16:47]

https://codereview.chromium.org/2639693002/diff/1/runtime/vm/simulator_arm64.cc
File runtime/vm/simulator_arm64.cc (right):

https://codereview.chromium.org/2639693002/diff/1/runtime/vm/simulator_arm64....
runtime/vm/simulator_arm64.cc:2681: static_cast<__int128>(rn_val) *
static_cast<__int128>(rm_val);
On 2017/01/17 20:18:04, zra wrote:
> Is this one signed or unsigned?

I'll add unsigned here as well. The code generated by gcc is the same.

[Florian Schneider, 2017-01-17 21:23:52]

Description was changed from

==========
VM: Fix umulh on simarm64 Windows.

Also add correct suffix for uint64_t in another place.

BUG=
==========

to

==========
VM: Fix umulh on simarm64 Windows.

Also add correct suffix for uint64_t in another place.

BUG=
R=zra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/13383d7f85b96b75d2c190b4dabf05fe0b653165
==========

[Florian Schneider, 2017-01-17 21:23:52]

Committed patchset #2 (id:20001) manually as
13383d7f85b96b75d2c190b4dabf05fe0b653165 (presubmit successful).