Use a better stack bound in DartEntry::InvokeFunction

Use a better stack bound in DartEntry::InvokeFunction

Fixes https://github.com/dart-lang/sdk/issues/28282
Fixes https://github.com/dart-lang/sdk/issues/28304

BUG=
R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/dc83d0ad7a5b9fae4962cffc7250e50546e2d5d1

[Cutch, 2017-01-17 20:05:05]

Description was changed from

==========
Use a better stack bound in DartEntry::InvokeFunction

Fixes https://github.com/dart-lang/sdk/issues/28282

BUG=
==========

to

==========
Use a better stack bound in DartEntry::InvokeFunction

Fixes https://github.com/dart-lang/sdk/issues/28282

BUG=
==========

[Cutch, 2017-01-17 20:05:05]

johnmccutchan@google.com changed reviewers:
+ asiva@google.com, kustermann@google.com

[Cutch, 2017-01-17 21:31:35]

Description was changed from

==========
Use a better stack bound in DartEntry::InvokeFunction

Fixes https://github.com/dart-lang/sdk/issues/28282

BUG=
==========

to

==========
Use a better stack bound in DartEntry::InvokeFunction

Fixes https://github.com/dart-lang/sdk/issues/28282
Fixes https://github.com/dart-lang/sdk/issues/28304

BUG=
==========

[siva, 2017-01-17 23:24:44]

lgtm

https://codereview.chromium.org/2639673003/diff/20001/runtime/vm/dart_entry.cc
File runtime/vm/dart_entry.cc (right):

https://codereview.chromium.org/2639673003/diff/20001/runtime/vm/dart_entry.c...
runtime/vm/dart_entry.cc:112: ScopedIsolateStackLimits stack_limit(thread,
current_sp);
Wondering if this needs to be pushed up to the top of this function as
Compiler::CompilerFunction could potentially run some Dart code.

[siva, 2017-01-17 23:25:19]

Thanks for fixing this.

[Cutch, 2017-01-17 23:29:02]

https://codereview.chromium.org/2639673003/diff/20001/runtime/vm/dart_entry.cc
File runtime/vm/dart_entry.cc (right):

https://codereview.chromium.org/2639673003/diff/20001/runtime/vm/dart_entry.c...
runtime/vm/dart_entry.cc:112: ScopedIsolateStackLimits stack_limit(thread,
current_sp);
On 2017/01/17 23:24:44, siva wrote:
> Wondering if this needs to be pushed up to the top of this function as
> Compiler::CompilerFunction could potentially run some Dart code.

Agreed. Done.

[Cutch, 2017-01-18 14:43:27]

Description was changed from

==========
Use a better stack bound in DartEntry::InvokeFunction

Fixes https://github.com/dart-lang/sdk/issues/28282
Fixes https://github.com/dart-lang/sdk/issues/28304

BUG=
==========

to

==========
Use a better stack bound in DartEntry::InvokeFunction

Fixes https://github.com/dart-lang/sdk/issues/28282
Fixes https://github.com/dart-lang/sdk/issues/28304

BUG=
R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/dc83d0ad7a5b9fae4962cffc7250e50546e2d5d1
==========

[Cutch, 2017-01-18 14:43:28]

Committed patchset #3 (id:40001) manually as
dc83d0ad7a5b9fae4962cffc7250e50546e2d5d1 (presubmit successful).