Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: content/browser/android/content_view_core_impl.cc

Issue 2639623002: Fixed Android text selection by redefining |button| value. (Closed)
Patch Set: Fixed WebPointerProperties comment. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/android/content_view_core_impl.cc
diff --git a/content/browser/android/content_view_core_impl.cc b/content/browser/android/content_view_core_impl.cc
index 41f7930b93f150cfbf46dc8d51038df98b43191b..b1f3ee55cefb65730c389c9ac95152faf0d49e6a 100644
--- a/content/browser/android/content_view_core_impl.cc
+++ b/content/browser/android/content_view_core_impl.cc
@@ -966,22 +966,20 @@ jboolean ContentViewCoreImpl::OnTouchEvent(
: rwhv->OnTouchEvent(event);
}
-jboolean ContentViewCoreImpl::SendMouseEvent(
- JNIEnv* env,
- const JavaParamRef<jobject>& obj,
- jlong time_ms,
- jint android_action,
- jfloat x,
- jfloat y,
- jint pointer_id,
- jfloat pressure,
- jfloat orientation,
- jfloat tilt,
- jint android_changed_button,
- jint android_button_state,
- jint android_meta_state,
- jint android_tool_type) {
-
+jboolean ContentViewCoreImpl::SendMouseEvent(JNIEnv* env,
+ const JavaParamRef<jobject>& obj,
+ jlong time_ms,
+ jint android_action,
+ jfloat x,
+ jfloat y,
+ jint pointer_id,
+ jfloat pressure,
+ jfloat orientation,
+ jfloat tilt,
+ jint android_action_button,
+ jint android_button_state,
+ jint android_meta_state,
+ jint android_tool_type) {
RenderWidgetHostViewAndroid* rwhv = GetRenderWidgetHostViewAndroid();
if (!rwhv)
return false;
@@ -1012,7 +1010,7 @@ jboolean ContentViewCoreImpl::SendMouseEvent(
// Note: This relies on identical button enum values in MotionEvent and
// MotionEventAndroid.
- rwhv->SendMouseEvent(motion_event, android_changed_button);
+ rwhv->SendMouseEvent(motion_event, android_action_button);
return true;
}

Powered by Google App Engine
This is Rietveld 408576698