Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java

Issue 2639533003: [Content suggestions] Report updates in the UI to UMA. (Closed)
Patch Set: Fix errors #2 Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java
index e393cafc04fa1e8155fcffbc27b8ea47a4557c23..5863f0735a06df8829ad9c1f4ef2453dce2e91f9 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java
@@ -8,6 +8,7 @@ import org.chromium.base.Callback;
import org.chromium.base.Log;
import org.chromium.base.VisibleForTesting;
import org.chromium.chrome.browser.ntp.NewTabPage.DestructionObserver;
+import org.chromium.chrome.browser.ntp.NewTabPageUma;
import org.chromium.chrome.browser.ntp.snippets.CategoryInt;
import org.chromium.chrome.browser.ntp.snippets.CategoryStatus.CategoryStatusEnum;
import org.chromium.chrome.browser.ntp.snippets.SectionHeader;
@@ -328,11 +329,13 @@ public class SuggestionsSection extends InnerNode {
if (replaceExisting && hasSuggestions()) {
if (CardsVariationParameters.ignoreUpdatesForExistingSuggestions()) {
Log.d(TAG, "setSuggestions: replacing existing suggestion disabled");
+ NewTabPageUma.recordUIUpdateResult(NewTabPageUma.UI_UPDATE_FAIL_DISABLED);
return;
}
if (mNumberOfSuggestionsSeen >= getSuggestionsCount()) {
Log.d(TAG, "setSuggestions: replacing existing suggestion not possible, all seen");
+ NewTabPageUma.recordUIUpdateResult(NewTabPageUma.UI_UPDATE_FAIL_ALL_SEEN);
return;
}
@@ -354,7 +357,22 @@ public class SuggestionsSection extends InnerNode {
suggestions.size() - targetCountToAppend);
suggestions.subList(targetCountToAppend, suggestions.size()).clear();
}
+
+ if (mNumberOfSuggestionsSeen == 1) {
+ NewTabPageUma.recordUIUpdateResult(NewTabPageUma.UI_UPDATE_SUCCESS_1_SEEN);
+ } else if (mNumberOfSuggestionsSeen == 2) {
+ NewTabPageUma.recordUIUpdateResult(NewTabPageUma.UI_UPDATE_SUCCESS_2_SEEN);
+ } else if (mNumberOfSuggestionsSeen == 3) {
+ NewTabPageUma.recordUIUpdateResult(NewTabPageUma.UI_UPDATE_SUCCESS_3_SEEN);
+ } else {
+ NewTabPageUma.recordUIUpdateResult(
+ NewTabPageUma.UI_UPDATE_SUCCESS_MORE_THAN_3_SEEN);
+ }
+ } else {
+ NewTabPageUma.recordUIUpdateResult(NewTabPageUma.UI_UPDATE_SUCCESS_NONE_SEEN);
}
+ } else {
+ NewTabPageUma.recordUIUpdateResult(NewTabPageUma.UI_UPDATE_SUCCESS_APPENDED);
}
mProgressIndicator.setVisible(SnippetsBridge.isCategoryLoading(status));

Powered by Google App Engine
This is Rietveld 408576698