Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Issue 263953003: Re-enable ActivityLog AdNetworkDatabase unittest (Closed)

Created:
6 years, 7 months ago by Devlin
Modified:
6 years, 7 months ago
Reviewers:
felt
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Re-enable ActivityLog AdNetworkDatabase unittest Re-enabling the test required a bit of a refactor. The implementation of AdNetworkDatabase is now public as HashedAdNetworkDatabase (name change from AdNetworkDatabaseImpl at Kalman's request). BUG=369656 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268714

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -492 lines) Patch
M chrome/browser/extensions/activity_log/ad_network_database.cc View 1 2 chunks +6 lines, -93 lines 0 comments Download
D chrome/browser/extensions/activity_log/ad_network_database_unittest.cc View 1 chunk +0 lines, -219 lines 0 comments Download
A chrome/browser/extensions/activity_log/hashed_ad_network_database.h View 1 1 chunk +36 lines, -0 lines 0 comments Download
A + chrome/browser/extensions/activity_log/hashed_ad_network_database.cc View 1 2 4 chunks +8 lines, -76 lines 0 comments Download
A + chrome/browser/extensions/activity_log/hashed_ad_network_database_unittest.cc View 3 chunks +17 lines, -103 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Devlin
6 years, 7 months ago (2014-05-02 21:39:59 UTC) #1
felt
On 2014/05/02 21:39:59, D Cronin wrote: lgtm, looks like a straightforward refactor I don't see ...
6 years, 7 months ago (2014-05-06 17:04:01 UTC) #2
Devlin
On 2014/05/06 17:04:01, felt wrote: > On 2014/05/02 21:39:59, D Cronin wrote: > > lgtm, ...
6 years, 7 months ago (2014-05-06 17:07:42 UTC) #3
Devlin
The CQ bit was checked by rdevlin.cronin@chromium.org
6 years, 7 months ago (2014-05-06 22:07:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/263953003/60001
6 years, 7 months ago (2014-05-06 22:10:30 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-07 04:16:17 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-07 11:25:44 UTC) #7
Message was sent while issue was closed.
Change committed as 268714

Powered by Google App Engine
This is Rietveld 408576698